workaround for require.resolve in prettier-vscode #7951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thorn0
force-pushed
the
require-resolve-workaround
branch
2 times, most recently
from
721a6ae
to
c1eda46
Compare
thorn0
force-pushed
the
require-resolve-workaround
branch
from
c1eda46
to
e56d19e
Compare
fisker
approved these changes
Apr 4, 2020
| const Module = eval("require")("module"); | ||
| const createRequire = Module.createRequire || Module.createRequireFromPath; | ||
| resolve = createRequire(__dirname).resolve; | ||
| } |
There was a problem hiding this comment.
I guess unnecessary to do another length check.
There was a problem hiding this comment.
I mean do we need check resolve.length again and throw an error if length still 1, but I guess it's unnecessary.
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #7949
✨Try the playground for this PR✨