Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw original error when loading external config #7973

Merged
merged 6 commits into from
Apr 10, 2020
Merged

Throw original error when loading external config #7973

merged 6 commits into from
Apr 10, 2020

Conversation

fisker
Copy link
Member

@fisker fisker commented Apr 7, 2020

See #7949 (comment)

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/pr-XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

✨Try the playground for this PR✨

@fisker

This comment has been minimized.

Sign in to view
@fisker fisker changed the title Throw original error when loading external config [WIP] Throw original error when loading external config Apr 7, 2020
@thorn0
Copy link
Member

thorn0 commented Apr 7, 2020

You can probably use expect.stringMatching and expect.stringContaining instead of snapshots, like I did in patterns-dirs.js.

@fisker
Copy link
Member Author

fisker commented Apr 7, 2020

Thanks I'll try

@fisker fisker changed the title [WIP] Throw original error when loading external config Throw original error when loading external config Apr 8, 2020
@fisker fisker requested a review from thorn0 April 10, 2020 13:21
@fisker fisker merged commit aeeb2ff into prettier:master Apr 10, 2020
@fisker fisker deleted the throw-original-error branch April 10, 2020 13:27
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@thorn0 thorn0 thorn0 approved these changes

@alexander-akait alexander-akait alexander-akait approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fisker @thorn0 @alexander-akait