Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump @typescript-eslint/typescript-estree from 2.34.0 to 3.0.0 #8384

Conversation

dependabot-preview[bot]
Copy link
Contributor

Bumps @typescript-eslint/typescript-estree from 2.34.0 to 3.0.0.

Release notes

Sourced from @typescript-eslint/typescript-estree's releases.

v3.0.0

This major release has been a long time coming! We've been saving up breaking changes for a while now, waiting for the ESLint v7 release which we knew would deprecate support for node version 8.

Due to our weekly release cadence, this major release mostly contains breaking changes!

Breaking Changes

Dropped support for Node version 8 (#1420)

In line with ESLint v7 - we've also dropped explicit support for node version 8. This version of node has been end of life since 2019-12-31. We no longer test against the version, so we provide no guarantees about whether or not future versions of our tooling will work on it.

Dropped support for TypeScript 3.2 (#2004)

Old TS versions cause us maintenance pain as we work on integrating tightly with the TypeScript APIs for performance and stability reasons.

As such we've updated our required TS version range to require a minimum of >=3.3.1.

Each version of TS brings bugfixes and features, but most importantly they bring performance improvements. TS 3.9 is releasing with a host of performance improvements that will improve both your build times, and your lint times - so you should endeavour to upgrade if you can. We cannot provide any guarantees around the performance of old TS versions.

Configs

We've updated all of our configs! We've added new rules, old rules, and removed some stylistic rules.

Both of the recommended and recommended-requiring-typechecking sets now inherit from the eslint-recommended set. We noticed that the majority of the time, users were using the sets in tandem, so this just removes one line of config for everyone.

Check out the linked issues for more information about added/removed rules:

  • eslint-recommended config (#1273)
  • recommended config (#1423)
  • recommended-requiring-typechecking (#1423)

Rules Changes

  • ban-types got a rework of its default ban list to provide some more sensible defaults and remove fixers that caused users issues. (#848)
  • no-floating-promises now has the ignoreVoid option set to true by default. (#2003)
  • no-non-null-asserted-optional-chain (non-breaking) now supports TS 3.9's non-null assertion changes.
  • no-unnecessary-condition
    • the ignoreRHS option has been removed. The rule will now only check the RHS when it matters (i.e. in boolean contexts). (#1163)
    • the checkArrayPredicates option has been removed. The rule will now always check array predicate functions. (#1579)
    • the rule now will report if you do an equality check against null/undefined when the value is not nullable. (#1659)
  • prefer-nullish-coalescing (52b60852d0ba6bb6abe519c9d3ec1b231793e91d)
    • the fixer has been converted to a suggestion fixer always - it was unsafe in most cases.
    • removed option forceSuggestionFixer.
  • prefer-optional-chain (52b60852d0ba6bb6abe519c9d3ec1b231793e91d)
    • the fixer has been converted to a suggestion fixer always - it was unsafe in a number of cases.
    • removed option suggestInsteadOfAutofix.
  • restrict-template-expressions
    • now has the allowNumber option set to true by default. (#2005)
    • allowNullable has been renamed to allowNullish. (#2006)
... (truncated)
Changelog

Sourced from @typescript-eslint/typescript-estree's changelog.

3.0.0 (2020-05-21)

Please see the release notes for v3.0.0

Bug Fixes

  • typescript-estree: remove now defunct Import node type (f199cbd)
  • typescript-estree: use TSEmptyBodyFunctionExpression for body-less nodes (#1289) (82e7163)

Features

  • add index files to parser and typescript-estree (3dfc46d)
  • bump minimum required TS version (#2004) (7ad4d7c)
  • eslint-plugin: [ban-types] rework default options (#848) (8e31d5d)
  • typescript-estree: align nodes with estree 2020 (#1389) (aff5b62)
  • typescript-estree: align optional fields (#1429) (0e0010f)
  • drop support for node v8 (#1997) (b6c3b7b)
  • typescript-estree: always return parserServices (#716) (5b23443)
  • typescript-estree: handle 3.9's non-null assertion changes (#2036) (06bec63)
Commits
  • 7e39f5b v3.0.0
  • 3dfc46d feat: add index files to parser and typescript-estree
  • f199cbd fix(typescript-estree): remove now defunct Import node type
  • 7ad4d7c feat: bump minimum required TS version (#2004)
  • aff5b62 feat(typescript-estree): align nodes with estree 2020 (#1389)
  • 0e0010f feat(typescript-estree): align optional fields (#1429)
  • b6c3b7b feat: drop support for node v8 (#1997)
  • 5b23443 feat(typescript-estree): always return parserServices (#716)
  • 82e7163 fix(typescript-estree): use TSEmptyBodyFunctionExpression for body-less nod...
  • 8e31d5d feat(eslint-plugin): [ban-types] rework default options (#848)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

@dependabot-preview dependabot-preview bot added the scope:dependency Issues that cannot be solved inside Prettier itself, and must be fixed in a dependency label May 22, 2020
@fisker
Copy link
Sponsor Member

fisker commented May 22, 2020

@dependabot-preview
Copy link
Contributor Author

Superseded by #8413.

@dependabot-preview dependabot-preview bot deleted the dependabot/npm_and_yarn/typescript-eslint/typescript-estree-3.0.0 branch May 26, 2020 08:48
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
scope:dependency Issues that cannot be solved inside Prettier itself, and must be fixed in a dependency
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant