JS: clean up babel plugins #8435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fisker
commented
May 28, 2020
src/language-js/parser-babel.js
Outdated
| "functionBind", | ||
| "functionSent", | ||
| "dynamicImport", | ||
| // "dynamicImport", // Need ref |
There was a problem hiding this comment.
Can't find a link says this enabled, but removing it seems no effect, the ast is also right
"callee": {
"type": "Import",
"start": 0,
"end": 6,
"loc": {
"start": { "line": 1, "column": 0 },
"end": { "line": 1, "column": 6 }
}
},
alexander-akait
approved these changes
May 28, 2020
fisker
commented
May 28, 2020
| |> # + "!" | ||
| |> new User.Message(#) | ||
| |> await # | ||
| |> console.log; // This is a method call. |
There was a problem hiding this comment.
Why this pipeline format like this? Bug?
There was a problem hiding this comment.
Sorry, I'm not sure why you think this is a bug. Could you explain?
There was a problem hiding this comment.
Shouldn't it be
value
|> await #
|> doubleSay(#, ", ")
|> capitalize // This is a function call.
|> # + "!"
|> new User.Message(#)
|> await #
|> console.log; // This is a method call.All aligned?
There was a problem hiding this comment.
Seems happens in && too, I'll open an issue later.
There was a problem hiding this comment.
probably you mistook the issue number:smile:
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8430
docs/directory)changelog_unreleased/*/pr-XXXX.mdfile followingchangelog_unreleased/TEMPLATE.md.✨Try the playground for this PR✨