Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(#73/#125): add glob regex group cases #184

Merged
merged 2 commits into from
Jan 17, 2024

Conversation

SukkaW
Copy link
Contributor

@SukkaW SukkaW commented Jan 17, 2024

Closes #73
Closes #125

By replacing the multimatch with picomatch in #180, I accidentally fix #73 and #125 (multimatch doesn't support regex grouping in the glob pattern, while picomatch supports). The PR adds test cases to verify that both issues have been fixed.

Copy link

changeset-bot bot commented Jan 17, 2024

⚠️ No Changeset found

Latest commit: 1fea4a9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@SukkaW SukkaW changed the title test(#73/#125): add glob regex group test(#73/#125): add glob regex group cases Jan 17, 2024
Copy link

codesandbox-ci bot commented Jan 17, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@codecov-commenter
Copy link

codecov-commenter commented Jan 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (71aab56) 85.45% compared to head (1fea4a9) 85.45%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #184   +/-   ##
=======================================
  Coverage   85.45%   85.45%           
=======================================
  Files           8        8           
  Lines         165      165           
  Branches       49       49           
=======================================
  Hits          141      141           
  Misses         21       21           
  Partials        3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

test/pattern.spec.ts Outdated Show resolved Hide resolved
@JounQin
Copy link
Member

JounQin commented Jan 17, 2024

Great job!

Co-authored-by: JounQin <admin@1stg.me>
@JounQin JounQin merged commit 1536657 into prettier:master Jan 17, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Round brackets pattern not working pattern doesn't work as expected
3 participants