feat(button): make standalone

[alexciesielski]

Tracked in #15465

Introduces the standalone API starting with the button component and directive.

Once given the green light by @cetincakiroglu I will go ahead and open subsequent PRs making more components and directives standalone.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
primeng	⬜️ Ignored (Inspect)	Visit Preview		May 21, 2024 6:30am

[alexciesielski]

An fdescribe was added 4 days ago, and after removing it a huge amount of unit tests is failing 🧐 unrelated to the change...

[cetincakiroglu]

Hi,

Thanks a lot for the effort and support, we'll review and test if it breaks anything during the build/deployment etc. It'll be merged in this or next week's milestone.

[kyjus25]

Super awesome you're even taking the time to break out CommonModule's import into importing the separate directives for smaller bundles. 🙏 Excited for this, thanks!

[cetincakiroglu]

Hi @alexciesielski ,

I've reviewed the button, ripple, shared & autofocus. I guess other files are unrelated. Thanks a lot for the effort and support. Could you please remove unrelated files, rebase the master and update the PR so I can merge it safely? You can continue to make the rest of the components standalone.

By doing so:
1-) If you'll send this in pieces as separate PRs, open an issue as RelatedComponentName | Standalone. If you'll send in a pack you can just create a checklist in the issue #15465
2-) Link the issue with a PR.
3-) Be sure you pull the latest updates from the master branch. In your PR there are updates in autofocus but not the recent one which leads to conflicts.

Again, thanks a lot for the effort and support! We're waiting for the rest.

[alexciesielski]

Hey, I rebased the branch and removed the changes to the contextmenu.spec.ts. Or do you mean anything else with "unrelated"? I tried to fix the usage in the tests as well but unfortunately running npm t still throws a lot of errors so I'm not sure what to do here

[cetincakiroglu]

Hey, I rebased the branch and removed the changes to the contextmenu.spec.ts. Or do you mean anything else with "unrelated"? I tried to fix the usage in the tests as well but unfortunately running npm t still throws a lot of errors so I'm not sure what to do here

Hi,

Yes, only the standalone related code. A contributor is currently working on tests. You can ignore them.

[alexciesielski]

The tests can't declare the Button component themselves because that will throw errors. Or do you expect the contributor to adjust that as well?

Edit: ok, will ignore them and remove the changes

[cetincakiroglu]

The tests can't declare the Button component themselves because that will throw errors. Or do you expect the contributor to adjust that as well?

Edit: ok, will ignore them and remove the changes

You can fix import/export/declaration errors related to your update to make it work. It would great to add only standalone component transition + broken test cases related to this process

[alexciesielski]

Ok, that's what I've done ✅ all changes are related to standalone transition

[alexciesielski]

Shall we get this merged this week? I would like to start refactoring other components to standalone but obviously need these changes first, as the pTemplate directive is used in lots of places.