Make DynamicDialog more flexible, fix docs #5679
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will add the following changes: - Allow for container template - Move content component into obj - Seperate child component props & emits - Rename dialogProps to seperate from child component props
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
|
Thank you for your recent PR. We appreciate your effort and dedication to improving our project. However, after careful review, we inform you that we are unable to accept the PR at this time due to the presence of breaking changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request aims to improve the DynamicDialog by making it a bit more flexible to use and also fix a few annoying gripes i've found with it (especially with handling emits and props):
Here's a quick summary:
Allow for
containertemplatePretty self explanatary, it will allow the dynamicDialog to also have a "headless" mode similar to the Dialog component itself.
Move content component into obj
This is caused by the point above, since you don't need a content component if you're declaring the container directly.
Seperate child component props & emits
I've noticed that there's no official documented way to send props to the child component so i've dug deeper and found out that emits just v-bind's directly to the child component. Theoretically you could use
options.emitsto pass props but i've found it kinda weird to use and not logical.Rename dialogProps to seperate from child component props
Since the dialog also has it own props i've reused the
options.propsfor the child component (similar tooptions.emits) and moved the dialog props intooptions.dialogProps.The changes i've made are ❗BREAKING❗ but i think they offer enough value to justify the additional migration step when updating the library.