Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed radio controls for stories #512

Closed
wants to merge 3 commits into from

Conversation

MadMango
Copy link

@MadMango MadMango commented Dec 11, 2023

Summary

I was playing around with storybook and I noticed that in a lot of playgrounds the controls didn't work.
I moved the options property so that they work again and I've made them all inline-radio for consistency, most other working examples use inline.

Not sure what I'm doing with changeset so if it needs to look any different, please let me know 馃槃

List of notable changes:

  • moved options property so that controls work
  • made all radios inline
  • removed some spread operators

What should reviewers focus on?

Controls in storybook

Steps to test:

Open storybook for one of the following components and use the controls:

  • Avatar
  • Button
  • ButtonGroup
  • CTABanner
  • ComparisonTable
  • Image
  • Label
  • Pillar
  • SectionIntro
  • Testimonial
  • Animation
  • UnorderedList

Contributor checklist:

  • All new and existing CI checks pass
  • Tests prove that the feature works and covers both happy and unhappy paths
  • Any drop in coverage, breaking changes or regressions have been documented above
  • New visual snapshots have been generated / updated for any UI changes
  • All developer debugging and non-functional logging has been removed
  • Related issues have been referenced in the PR description

Reviewer checklist:

  • Check that pull request and proposed changes adhere to our contribution guidelines and code of conduct
  • Check that tests prove the feature works and covers both happy and unhappy paths
  • Check that there aren't other open Pull Requests for the same update/change

Screenshots:

Before After

image

image

Copy link

changeset-bot bot commented Dec 11, 2023

鈿狅笍 No Changeset found

Latest commit: daa7a92

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@MadMango MadMango marked this pull request as ready for review December 11, 2023 17:45
@MadMango MadMango changed the title fixed radio controls for stories Fixed radio controls for stories Dec 11, 2023
@rezrah rezrah added the brand label Dec 18, 2023
Comment on lines 1 to 5
---
'@primer/brand-storybook': patch
---

Fixed radio controls for stories
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MadMango! We actually don't need a changeset for Storybook changes. Can you please remove this?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem, that's done now 馃檪

@rezrah rezrah self-assigned this Jan 22, 2024
@MadMango MadMango closed this May 27, 2024
@MadMango MadMango deleted the madmango/stories-controls branch May 27, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants