Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Single page component docs prototype #294

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from
Draft

[WIP] Single page component docs prototype #294

wants to merge 13 commits into from

Conversation

langermank
Copy link
Contributor

WIP :)

broccolinisoup
broccolinisoup reviewed Sep 15, 2022
View reviewed changes
src/SubNav.jsx Outdated Show resolved Hide resolved
langermank
langermank commented Sep 16, 2022
View reviewed changes
src/LookbookEmbed.jsx Outdated Show resolved Hide resolved
langermank and others added 2 commits September 16, 2022 07:25
@langermank @broccolinisoup
Update src/LookbookEmbed.jsx
b9dd077 
Co-authored-by: Armağan <broccolinisoup@github.com>
@langermank
setup mock prop table
edba507
@langermank
Copy link
Contributor Author

@emilybrick I spent the week setting us up with some infrastructure to support the single page prototype 😄

  • Lookbook and Storybook iframe components that we can pass specific stories/previews to render
  • UnderlineNav support (its not perfect but its a start)
  • PropsTable component that can populate from JSON data. I added some mock data for now, but it would be interesting to try and source this from both React and Rails
  • Added some components and a template to this interface guidelines Figma library. Might be a good place to think about how the Usage section should look (section requirements, etc.)

@josepmartins josepmartins mentioned this pull request Sep 20, 2022
Closed
4 tasks
@langermank langermank temporarily deployed to github-pages September 20, 2022 19:55 Inactive
@langermank langermank temporarily deployed to github-pages September 20, 2022 21:59 Inactive
@langermank langermank temporarily deployed to github-pages September 23, 2022 22:55 Inactive
@langermank langermank temporarily deployed to github-pages September 24, 2022 00:42 Inactive
@langermank langermank temporarily deployed to github-pages September 24, 2022 01:07 Inactive
@josepmartins josepmartins mentioned this pull request Nov 17, 2022
Closed
4 tasks
@simurai simurai mentioned this pull request Jan 25, 2023
Merged
7 tasks
@josepmartins josepmartins mentioned this pull request Jan 30, 2023
Merged
@simurai
Copy link
Contributor

simurai commented Jan 31, 2023

FYI: #364 includes the StorybookEmbed for the utilities and probably will cause merge conflicts with this PR. 😇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@broccolinisoup broccolinisoup broccolinisoup left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@langermank @simurai @broccolinisoup