Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add overlay-offset var + docs #803

Merged
merged 4 commits into from
Feb 14, 2024
Merged

Add overlay-offset var + docs #803

merged 4 commits into from
Feb 14, 2024

Conversation

langermank
Copy link
Contributor

Adds a size var to be used by overlays like Tooltip, ActionMenu etc that are anchored to a trigger.

@langermank langermank requested a review from a team as a code owner February 13, 2024 18:30
@langermank langermank requested review from a team, jonrohan and broccolinisoup February 13, 2024 18:30
Copy link

changeset-bot bot commented Feb 13, 2024

🦋 Changeset detected

Latest commit: 327e2c7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/primitives Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Feb 13, 2024

Variables changed
No variables changed

Copy link
Contributor

github-actions bot commented Feb 13, 2024

Design Token Diff

/css/functional/size/size.css

+++ /home/runner/work/primitives/primitives/tokens-next-private/css/functional/size/size.css	2024-02-13 21:43:01.232752508 +0000
@@ -70,4 +70,5 @@
 --overlay-paddingBlock-condensed: 0.25rem;
 --overlay-paddingBlock-normal: 0.75rem;
 --overlay-borderRadius: 0.375rem;
+  --overlay-offset: 0.25rem;
}

@github-actions github-actions bot temporarily deployed to storybook-preview February 13, 2024 18:37 Inactive
@langermank langermank added the update snapshots Update visual regression test snapshots label Feb 13, 2024
@github-actions github-actions bot removed the update snapshots Update visual regression test snapshots label Feb 13, 2024
@primer primer bot temporarily deployed to github-pages February 13, 2024 21:43 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview February 13, 2024 21:44 Inactive
@langermank langermank merged commit fce6921 into main Feb 14, 2024
26 checks passed
@langermank langermank deleted the add-overlay-offset-var branch February 14, 2024 20:11
@primer primer bot mentioned this pull request Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant