Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Darken muted border-color to 70% opacity #804

Merged
merged 3 commits into from
Feb 16, 2024
Merged

Darken muted border-color to 70% opacity #804

merged 3 commits into from
Feb 16, 2024
+7 −2

Conversation

langermank
Copy link
Contributor

@langermank langermank commented Feb 14, 2024 •
edited
Loading

We've gotten some feedback that the muted border-color is just a bit too light. This increases the opacity a tad.

@langermank
darken muted border
Loading
Loading status checks…
27d57be
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 14, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 05a2fee

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/primitives Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 14, 2024 •
edited
Loading

Variables changed 
No variables changed

@langermank
Create unlucky-crews-camp.md
Loading
Loading status checks…
ed22979
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 14, 2024 •
edited
Loading

Design Token Diff

/css/functional/themes/dark-colorblind.css

 
+++ /home/runner/work/primitives/primitives/tokens-next-private/css/functional/themes/dark-colorblind.css	2024-02-16 00:09:47.392998496 +0000
@@ -43,7 +43,7 @@
 --headerSearch-bgColor: #0d1117;
 --headerSearch-borderColor: #30363d;
 --avatar-bgColor: #ffffff1a;
-  --avatar-borderColor: #30363d80;
+  --avatar-borderColor: #30363db3;
 --avatar-shadow: 0px 0px 0px 2px #0d1117;
 --avatarStack-fade-bgColor-default: #30363d;
 --avatarStack-fade-bgColor-muted: #21262d;
@@ -234,7 +234,7 @@
 --bgColor-sponsors-muted: #db61a21a;
 --bgColor-sponsors-emphasis: #bf4b8a;
 --borderColor-default: #30363d;
-  --borderColor-muted: #30363d80;
+  --borderColor-muted: #30363db3;
 --borderColor-emphasis: #484f58;
 --borderColor-disabled: #161b22;
 --borderColor-transparent: #00000000;
@@ -452,7 +452,7 @@
   --headerSearch-bgColor: #0d1117;
   --headerSearch-borderColor: #30363d;
   --avatar-bgColor: #ffffff1a;
-    --avatar-borderColor: #30363d80;
+    --avatar-borderColor: #30363db3;
   --avatar-shadow: 0px 0px 0px 2px #0d1117;
   --avatarStack-fade-bgColor-default: #30363d;
   --avatarStack-fade-bgColor-muted: #21262d;
@@ -643,7 +643,7 @@
   --bgColor-sponsors-muted: #db61a21a;
   --bgColor-sponsors-emphasis: #bf4b8a;
   --borderColor-default: #30363d;
-    --borderColor-muted: #30363d80;
+    --borderColor-muted: #30363db3;
   --borderColor-emphasis: #484f58;
   --borderColor-disabled: #161b22;
   --borderColor-transparent: #00000000;

/css/functional/themes/dark-dimmed.css

 
+++ /home/runner/work/primitives/primitives/tokens-next-private/css/functional/themes/dark-dimmed.css	2024-02-16 00:09:46.713003948 +0000
@@ -43,7 +43,7 @@
 --headerSearch-bgColor: #22272e;
 --headerSearch-borderColor: #444c56;
 --avatar-bgColor: #cdd9e51a;
-  --avatar-borderColor: #444c5680;
+  --avatar-borderColor: #444c56b3;
 --avatar-shadow: 0px 0px 0px 2px #22272e;
 --avatarStack-fade-bgColor-default: #444c56;
 --avatarStack-fade-bgColor-muted: #373e47;
@@ -234,7 +234,7 @@
 --bgColor-sponsors-muted: #c961981a;
 --bgColor-sponsors-emphasis: #ae4c82;
 --borderColor-default: #444c56;
-  --borderColor-muted: #444c5680;
+  --borderColor-muted: #444c56b3;
 --borderColor-emphasis: #545d68;
 --borderColor-disabled: #2d333b;
 --borderColor-transparent: #00000000;
@@ -452,7 +452,7 @@
   --headerSearch-bgColor: #22272e;
   --headerSearch-borderColor: #444c56;
   --avatar-bgColor: #cdd9e51a;
-    --avatar-borderColor: #444c5680;
+    --avatar-borderColor: #444c56b3;
   --avatar-shadow: 0px 0px 0px 2px #22272e;
   --avatarStack-fade-bgColor-default: #444c56;
   --avatarStack-fade-bgColor-muted: #373e47;
@@ -643,7 +643,7 @@
   --bgColor-sponsors-muted: #c961981a;
   --bgColor-sponsors-emphasis: #ae4c82;
   --borderColor-default: #444c56;
-    --borderColor-muted: #444c5680;
+    --borderColor-muted: #444c56b3;
   --borderColor-emphasis: #545d68;
   --borderColor-disabled: #2d333b;
   --borderColor-transparent: #00000000;

/css/functional/themes/dark-tritanopia.css

 
+++ /home/runner/work/primitives/primitives/tokens-next-private/css/functional/themes/dark-tritanopia.css	2024-02-16 00:09:47.029001414 +0000
@@ -43,7 +43,7 @@
 --headerSearch-bgColor: #0d1117;
 --headerSearch-borderColor: #30363d;
 --avatar-bgColor: #ffffff1a;
-  --avatar-borderColor: #30363d80;
+  --avatar-borderColor: #30363db3;
 --avatar-shadow: 0px 0px 0px 2px #0d1117;
 --avatarStack-fade-bgColor-default: #30363d;
 --avatarStack-fade-bgColor-muted: #21262d;
@@ -234,7 +234,7 @@
 --bgColor-sponsors-muted: #db61a21a;
 --bgColor-sponsors-emphasis: #bf4b8a;
 --borderColor-default: #30363d;
-  --borderColor-muted: #30363d80;
+  --borderColor-muted: #30363db3;
 --borderColor-emphasis: #484f58;
 --borderColor-disabled: #161b22;
 --borderColor-transparent: #00000000;
@@ -452,7 +452,7 @@
   --headerSearch-bgColor: #0d1117;
   --headerSearch-borderColor: #30363d;
   --avatar-bgColor: #ffffff1a;
-    --avatar-borderColor: #30363d80;
+    --avatar-borderColor: #30363db3;
   --avatar-shadow: 0px 0px 0px 2px #0d1117;
   --avatarStack-fade-bgColor-default: #30363d;
   --avatarStack-fade-bgColor-muted: #21262d;
@@ -643,7 +643,7 @@
   --bgColor-sponsors-muted: #db61a21a;
   --bgColor-sponsors-emphasis: #bf4b8a;
   --borderColor-default: #30363d;
-    --borderColor-muted: #30363d80;
+    --borderColor-muted: #30363db3;
   --borderColor-emphasis: #484f58;
   --borderColor-disabled: #161b22;
   --borderColor-transparent: #00000000;

/css/functional/themes/dark.css

 
+++ /home/runner/work/primitives/primitives/tokens-next-private/css/functional/themes/dark.css	2024-02-16 00:09:46.289007347 +0000
@@ -43,7 +43,7 @@
 --headerSearch-bgColor: #0d1117;
 --headerSearch-borderColor: #30363d;
 --avatar-bgColor: #ffffff1a;
-  --avatar-borderColor: #30363d80;
+  --avatar-borderColor: #30363db3;
 --avatar-shadow: 0px 0px 0px 2px #0d1117;
 --avatarStack-fade-bgColor-default: #30363d;
 --avatarStack-fade-bgColor-muted: #21262d;
@@ -234,7 +234,7 @@
 --bgColor-sponsors-muted: #db61a21a;
 --bgColor-sponsors-emphasis: #bf4b8a;
 --borderColor-default: #30363d;
-  --borderColor-muted: #30363d80;
+  --borderColor-muted: #30363db3;
 --borderColor-emphasis: #484f58;
 --borderColor-disabled: #161b22;
 --borderColor-transparent: #00000000;
@@ -452,7 +452,7 @@
   --headerSearch-bgColor: #0d1117;
   --headerSearch-borderColor: #30363d;
   --avatar-bgColor: #ffffff1a;
-    --avatar-borderColor: #30363d80;
+    --avatar-borderColor: #30363db3;
   --avatar-shadow: 0px 0px 0px 2px #0d1117;
   --avatarStack-fade-bgColor-default: #30363d;
   --avatarStack-fade-bgColor-muted: #21262d;
@@ -643,7 +643,7 @@
   --bgColor-sponsors-muted: #db61a21a;
   --bgColor-sponsors-emphasis: #bf4b8a;
   --borderColor-default: #30363d;
-    --borderColor-muted: #30363d80;
+    --borderColor-muted: #30363db3;
   --borderColor-emphasis: #484f58;
   --borderColor-disabled: #161b22;
   --borderColor-transparent: #00000000;

/css/functional/themes/light-colorblind.css

 
+++ /home/runner/work/primitives/primitives/tokens-next-private/css/functional/themes/light-colorblind.css	2024-02-16 00:09:45.501013664 +0000
@@ -235,7 +235,7 @@
 --bgColor-sponsors-muted: #ffeff7;
 --bgColor-sponsors-emphasis: #bf3989;
 --borderColor-default: #d0d7de;
-  --borderColor-muted: #d0d7de80;
+  --borderColor-muted: #d0d7deb3;
 --borderColor-emphasis: #6e7781;
 --borderColor-disabled: #f6f8fa;
 --borderColor-transparent: #ffffff00;
@@ -644,7 +644,7 @@
   --bgColor-sponsors-muted: #ffeff7;
   --bgColor-sponsors-emphasis: #bf3989;
   --borderColor-default: #d0d7de;
-    --borderColor-muted: #d0d7de80;
+    --borderColor-muted: #d0d7deb3;
   --borderColor-emphasis: #6e7781;
   --borderColor-disabled: #f6f8fa;
   --borderColor-transparent: #ffffff00;

/css/functional/themes/light-tritanopia.css

 
+++ /home/runner/work/primitives/primitives/tokens-next-private/css/functional/themes/light-tritanopia.css	2024-02-16 00:09:45.117016743 +0000
@@ -235,7 +235,7 @@
 --bgColor-sponsors-muted: #ffeff7;
 --bgColor-sponsors-emphasis: #bf3989;
 --borderColor-default: #d0d7de;
-  --borderColor-muted: #d0d7de80;
+  --borderColor-muted: #d0d7deb3;
 --borderColor-emphasis: #6e7781;
 --borderColor-disabled: #f6f8fa;
 --borderColor-transparent: #ffffff00;
@@ -644,7 +644,7 @@
   --bgColor-sponsors-muted: #ffeff7;
   --bgColor-sponsors-emphasis: #bf3989;
   --borderColor-default: #d0d7de;
-    --borderColor-muted: #d0d7de80;
+    --borderColor-muted: #d0d7deb3;
   --borderColor-emphasis: #6e7781;
   --borderColor-disabled: #f6f8fa;
   --borderColor-transparent: #ffffff00;

/css/functional/themes/light.css

 
+++ /home/runner/work/primitives/primitives/tokens-next-private/css/functional/themes/light.css	2024-02-16 00:09:44.561021201 +0000
@@ -235,7 +235,7 @@
 --bgColor-sponsors-muted: #ffeff7;
 --bgColor-sponsors-emphasis: #bf3989;
 --borderColor-default: #d0d7de;
-  --borderColor-muted: #d0d7de80;
+  --borderColor-muted: #d0d7deb3;
 --borderColor-emphasis: #6e7781;
 --borderColor-disabled: #f6f8fa;
 --borderColor-transparent: #ffffff00;
@@ -644,7 +644,7 @@
   --bgColor-sponsors-muted: #ffeff7;
   --bgColor-sponsors-emphasis: #bf3989;
   --borderColor-default: #d0d7de;
-    --borderColor-muted: #d0d7de80;
+    --borderColor-muted: #d0d7deb3;
   --borderColor-emphasis: #6e7781;
   --borderColor-disabled: #f6f8fa;
   --borderColor-transparent: #ffffff00;

@github-actions github-actions bot temporarily deployed to storybook-preview February 14, 2024 20:13 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview February 14, 2024 20:14 Inactive
@lukasoppermann lukasoppermann requested review from lukasoppermann and removed request for lukasoppermann February 15, 2024 08:52
@langermank langermank added the update snapshots Update visual regression test snapshots label Feb 16, 2024
@github-actions github-actions bot removed the update snapshots Update visual regression test snapshots label Feb 16, 2024
@primer primer bot temporarily deployed to github-pages February 16, 2024 00:10 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview February 16, 2024 00:11 Inactive
@langermank langermank marked this pull request as ready for review February 16, 2024 00:31
@langermank langermank requested a review from a team as a code owner February 16, 2024 00:31
@langermank langermank requested review from a team, tobiasahlin and broccolinisoup February 16, 2024 00:31
@langermank langermank merged commit 3d8a006 into main Feb 16, 2024
26 checks passed
@langermank langermank deleted the test-darker-muted-border branch February 16, 2024 00:31
@primer primer bot mentioned this pull request Feb 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukasoppermann lukasoppermann

@tobiasahlin tobiasahlin

@broccolinisoup broccolinisoup

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@langermank @lukasoppermann