Adding all color modes to figma export #805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 882384a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Variables changedNo variables changed |
lukasoppermann
temporarily deployed
to
github-pages
GitHub Actions
Inactive
lukasoppermann
temporarily deployed
to
github-pages
GitHub Actions
Inactive
lukasoppermann
temporarily deployed
to
github-pages
GitHub Actions
Inactive
langermank
reviewed
Feb 16, 2024
scripts/buildPlatforms/buildFigma.ts
Outdated
| @@ -30,7 +38,7 @@ export const buildFigma = (buildOptions: ConfigGeneratorOptions): void => { | |||
| } | |||
| // | |||
| for (const {filename, source, include} of themes) { | |||
| if (['light', 'dark'].includes(filename)) { | |||
| if (!['light-high-contrast', 'dark-high-contrast', 'dark-dimmed'].includes(filename)) { | |||
There was a problem hiding this comment.
What about color blind themes?
There was a problem hiding this comment.
This is just disabling them to test if they are problematic, they are. It is just a temp step.
langermank
approved these changes
Feb 16, 2024
|
So it works great for all modes that have no specific base scale, so everything but So I need to find a fix for those three. |
lukasoppermann
temporarily deployed
to
github-pages
GitHub Actions
Inactive
lukasoppermann
temporarily deployed
to
github-pages
GitHub Actions
Inactive
Design Token DiffNo design tokens changed |
lukasoppermann
force-pushed
the
@lukasoppermann/add-figma-colormodes
branch
from
79e6f0b to
1458cde
Compare
lukasoppermann
temporarily deployed
to
github-pages
GitHub Actions
Inactive
lukasoppermann
temporarily deployed
to
github-pages
GitHub Actions
Inactive
lukasoppermann
temporarily deployed
to
github-pages
GitHub Actions
Inactive
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds transformations to be able to import all colors modes into Figma.