ActionBar: Move to main directory (experimental → alpha) #4574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f183b91 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
Fix imports
siddharthkp
approved these changes
May 21, 2024
| @@ -67,8 +67,7 @@ export * from './SelectPanel2' | |||
| export {default as TabPanels} from './TabPanels' | |||
| export type {TabPanelsProps, TabPanelsTabProps, TabPanelsPanelProps} from './TabPanels' | |||
| export * from '../TooltipV2' | |||
| export {default as ActionBar} from './ActionBar' | |||
| export * from './ActionBar' | |||
| export * from '../ActionBar' | |||
There was a problem hiding this comment.
Kudos for backward compatibility for imports!
siddharthkp
reviewed
May 21, 2024
| "status": "draft", | ||
| "a11yReviewed": false, | ||
| "status": "alpha", | ||
| "a11yReviewed": true, |
siddharthkp
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #https://github.com/github/primer/issues/3020
Changelog
Make the component be imported from @primer/react and drafts. In next major release, we need to remove it from drafts
Rollout strategy
Testing & Reviewing
Merge checklist