Update NavList to use the new GroupHeading API and add an as
prop to specify the heading level (h3 to match with the default)
#4593
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While fixing tests on the eslint upgrade PR #4592, I realised that
<NavList.Group title="title">
is uses<ActionList.Group title="title">
under the hood and with eslint upgrade updating that usage to use the newActionList.GroupHeading
API, it throws an error as it requires anas
prop to specify the heading level.This PR, updates the old API to the new one on Navlist and specifies the heading level as h3 as per the default value. There shouldn't be any changes in the rendered HTML since we render the same HTML both for old and the new API for backward compatibility
Changelog
New
Changed
title
prop from theActionList.Group title={title}
and used<ActionList.GroupHeading>{title}</ActionList.GroupHeading>
as
prop to the<ActionList.GroupHeading>{title}</ActionList.GroupHeading>
since we require it for pure lists, meaning lists that are not in the context of menu or listbox. The value it the default value, h3.Removed
Rollout strategy
Testing & Reviewing
Make sure there is no snapshot changes in the rendered HTML.
Merge checklist