Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scrollbar-gutter prop to PageLayoutPane #4594

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dipree
Copy link
Contributor

@dipree dipree commented May 15, 2024

Without scrollbar-gutter (or set to auto)

CleanShot.2024-05-15.at.08.33.07.mp4

Set to scrollbar-gutter: stable

CleanShot.2024-05-15.at.08.34.27.mp4

https://developer.mozilla.org/en-US/docs/Web/CSS/scrollbar-gutter

Changelog

New

Changed

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

Copy link

changeset-bot bot commented May 15, 2024

⚠️ No Changeset found

Latest commit: 70ef9ac

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented May 15, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 88.36 KB (+0.02% 🔺)
packages/react/dist/browser.umd.js 88.6 KB (-0.05% 🔽)

@@ -608,6 +608,7 @@ export type PageLayoutPaneProps = {
dividerWhenNarrow?: 'inherit' | 'none' | 'line' | 'filled'
sticky?: boolean
offsetHeader?: string | number
scrollbarGutter?: 'auto' | 'stable' | 'stable both-edges' | 'always'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When would we want this not to be stable?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants