Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to retrieve the sparks of a given server #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lpinca
Copy link
Member

@lpinca lpinca commented Jul 9, 2015

This patch merges metroplex.spark and metroplex.sparks into metroplex.servers. This method now accepts an additional argument which can be a single spark id or an array of spark ids. If this argument is provided the method returns only the servers for the given spark id(s), otherwise it follows the old behavior. This is the new signature:

metroplex.servers(self, sparks, fn)

The old metroplex.sparks now returns the spark ids for the given server. It's new signature is the following:

metroplex.sparks(address, fn);

See discussion in #6.

P.S. The self argument was not documented and not so useful IMHO. I would like to remove it if the are no objections.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant