Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added deprecation warning for prisma introspect command #2134

Merged
merged 4 commits into from Aug 11, 2021
Merged

Added deprecation warning for prisma introspect command #2134

merged 4 commits into from Aug 11, 2021

Conversation

molebox
Copy link
Contributor

@molebox molebox commented Aug 11, 2021

No description provided.

@thebiglabasky
Copy link
Contributor

I'd move the deprecation warning from the reference section up, just below the header introspect

@Jolg42
Copy link
Member

Jolg42 commented Aug 11, 2021

Started to add comments like
I think we don't need a warning here, we could just rename?
But I think it applies in many places so stopping commenting to not spam

@Jolg42 Jolg42 linked an issue Aug 11, 2021 that may be closed by this pull request
Update docs to reflect that prisma introspect gets deprecated in favor of prisma db pull #2115
Closed
Jolg42
Jolg42 reviewed Aug 11, 2021
View reviewed changes
src/components/customMdx/admonition.tsx Outdated
Comment on lines 19 to 20
console.log({children})
const isMultiline: boolean = Array.isArray(children) ? true : false;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
console.log({children})
const isMultiline: boolean = Array.isArray(children) ? true : false;
const isMultiline: boolean = Array.isArray(children) ? true : false;

I think we should remove the console.log?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

face-palm

@Jolg42
Copy link
Member

Jolg42 commented Aug 11, 2021

Note: some images are showing prisma introspect
Like

Not sure how we can update these images (maybe for another day)

Jolg42
Jolg42 approved these changes Aug 11, 2021
View reviewed changes
Copy link
Member

@Jolg42 Jolg42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 馃檶馃徏 (see comments before merging)

@molebox
Copy link
Contributor Author

molebox commented Aug 11, 2021

Note: some images are showing prisma introspect
Like

Not sure how we can update these images (maybe for another day)

Yep i saw those! But thanks for making a list of them, thats super helpful. Will create another issue. I can probably handle most of them so long as they live in figma

@molebox molebox merged commit b99801d into main Aug 11, 2021
@molebox molebox deleted the deprecation-warning branch August 11, 2021 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jolg42 Jolg42 Jolg42 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update docs to reflect that prisma introspect gets deprecated in favor of prisma db pull
3 participants
@molebox @thebiglabasky @Jolg42