Add MySQL to full text search Concepts page #2678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update with MySQL functionality
|
✔️ Deploy Preview for prisma2-docs ready! 🔨 Explore the source changes: 5e490ea 🔍 Inspect the deploy log: https://app.netlify.com/sites/prisma2-docs/deploys/61dd5e61f87f1700082017b4 😎 Browse the preview: https://deploy-preview-2678--prisma2-docs.netlify.app |
keerlu
commented
Jan 7, 2022
content/200-concepts/100-components/02-prisma-client/060-full-text-search.mdx
Outdated
Show resolved
Hide resolved
keerlu
commented
Jan 7, 2022
content/200-concepts/100-components/02-prisma-client/060-full-text-search.mdx
Show resolved
Hide resolved
keerlu
commented
Jan 7, 2022
content/200-concepts/100-components/02-prisma-client/060-full-text-search.mdx
Outdated
Show resolved
Hide resolved
garrensmith
reviewed
Jan 7, 2022
There was a problem hiding this comment.
This is looking really good. I've given the MySql docs a fuller read and realised I missed some of its operators. I've added some examples in the comments. Very sorry about not telling you about those.
I've also tested the existing examples and they work as we specified
content/200-concepts/100-components/02-prisma-client/060-full-text-search.mdx
Outdated
Show resolved
Hide resolved
content/200-concepts/100-components/02-prisma-client/060-full-text-search.mdx
Show resolved
Hide resolved
content/200-concepts/100-components/02-prisma-client/060-full-text-search.mdx
Outdated
Show resolved
Hide resolved
janpio
reviewed
Jan 7, 2022
content/200-concepts/100-components/02-prisma-client/060-full-text-search.mdx
Outdated
Show resolved
Hide resolved
janpio
reviewed
Jan 7, 2022
content/200-concepts/100-components/02-prisma-client/060-full-text-search.mdx
Outdated
Show resolved
Hide resolved
Fix capitalisation of title
Remove second title and add TopBlock
Fix TypeScript formatting of examples
Add more MySQL full text search examples
…text-search.mdx Co-authored-by: Jan Piotrowski <piotrowski+github@gmail.com>
Include version information in introduction
Clarify terminology for feature vs feature flag
janpio
approved these changes
Jan 10, 2022
ruheni
reviewed
Jan 11, 2022
content/200-concepts/100-components/02-prisma-client/060-full-text-search.mdx
Outdated
Show resolved
Hide resolved
ruheni
reviewed
Jan 11, 2022
content/200-concepts/100-components/02-prisma-client/060-full-text-search.mdx
Outdated
Show resolved
Hide resolved
ruheni
reviewed
Jan 11, 2022
content/200-concepts/100-components/02-prisma-client/060-full-text-search.mdx
Show resolved
Hide resolved
ruheni
reviewed
Jan 11, 2022
content/200-concepts/100-components/02-prisma-client/060-full-text-search.mdx
Outdated
Show resolved
Hide resolved
…text-search.mdx Co-authored-by: Alex Ruheni <33921841+ruheni@users.noreply.github.com>
Update link to PostgreSQL documentation on full text indexes specifically
…text-search.mdx Co-authored-by: Alex Ruheni <33921841+ruheni@users.noreply.github.com>
Add P2030 fulltext error to the error reference
…into keerlu-fulltext-mysql
matthewmueller
pushed a commit
that referenced
this pull request
Jul 22, 2022
* Update 060-full-text-search.mdx Update with MySQL functionality * Update 060-full-text-search.mdx Fix capitalisation of title * Update 060-full-text-search.mdx Remove second title and add TopBlock * Update 060-full-text-search.mdx Fix TypeScript formatting of examples * Update 060-full-text-search.mdx Add more MySQL full text search examples * Update content/200-concepts/100-components/02-prisma-client/060-full-text-search.mdx Co-authored-by: Jan Piotrowski <piotrowski+github@gmail.com> * Update content/200-concepts/100-components/02-prisma-client/060-full-text-search.mdx * Update 060-full-text-search.mdx Include version information in introduction * Update 060-full-text-search.mdx Clarify terminology for feature vs feature flag * Update content/200-concepts/100-components/02-prisma-client/060-full-text-search.mdx Co-authored-by: Alex Ruheni <33921841+ruheni@users.noreply.github.com> * Update 060-full-text-search.mdx Update link to PostgreSQL documentation on full text indexes specifically * Update content/200-concepts/100-components/02-prisma-client/060-full-text-search.mdx Co-authored-by: Alex Ruheni <33921841+ruheni@users.noreply.github.com> * Update 250-error-reference.mdx Add P2030 fulltext error to the error reference Co-authored-by: Jan Piotrowski <piotrowski+github@gmail.com> Co-authored-by: Alex Ruheni <33921841+ruheni@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe this PR
I've added MySQL to the full text search Concepts page, which is currently PostgreSQL only. So far I've focussed just on getting the information in (from @garrensmith's comment here). Not sure what the best way to organise the information is yet but would appreciate a review of the technical content.
Changes
Added MySQL-specific information
What issue does this fix?
Any other relevant information