Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make index bullet a sub item of ref actions/integrity #2766

Closed
wants to merge 1 commit into from

Conversation

janpio
Copy link
Member

@janpio janpio commented Jan 25, 2022

See https://deploy-preview-2766--prisma2-docs.netlify.app/docs/guides/database/using-prisma-with-planetscale

This was what I meant by "make it a sub bullet point" (or however I expressed it). The Index requirement follows from the ref actions/integrity change.

image

Suggestion re #2708

@netlify
Copy link

netlify bot commented Jan 25, 2022

✔️ Deploy Preview for prisma2-docs ready!

🔨 Explore the source changes: 5524525

🔍 Inspect the deploy log: https://app.netlify.com/sites/prisma2-docs/deploys/61f02eab3f78120008f07244

😎 Browse the preview: https://deploy-preview-2766--prisma2-docs.netlify.app

@janpio janpio requested a review from keerlu January 25, 2022 17:21
Base automatically changed from planetscale-guide to main January 27, 2022 11:27
@keerlu
Copy link
Contributor

keerlu commented Jan 27, 2022

Sorry, I completely missed this PR. I considered a sub-bullet but just one looks very odd to me visually, more like a mistake than a deliberate subsection. I think this having the bullet immediately follow the 'referential actions' bullet is clear enough. Any thoughts @tanberry?

@tanberry
Copy link
Contributor

Yeah, I agree that having the single, indented sub-bullet looks like a formatting mistake. I think a solution is to leave it as a regular bullet, right beneath Referntial Actions/Integrity bullet, but add a sentence at the very beginning saying something like:

"Related to the use of referential actions is the use of foreign keys."

Also, @keerlu instead of using the word "As..." use the word "Because..." (That's another translation thing... the word "as" is just too squirelly a word.)

@janpio
Copy link
Member Author

janpio commented Jan 27, 2022

To me the "visual mistake" actually represents the visual hierarchy of the content.. But you take it from here.

@janpio janpio changed the base branch from main to planetscale-guide January 28, 2022 11:09
@janpio
Copy link
Member Author

janpio commented Jan 28, 2022

(I restored and changed the target branch to make it visible again what this PR really changes)

@janpio janpio closed this Jan 28, 2022
@janpio janpio deleted the janpio-patch-10 branch March 30, 2022 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants