Client constructor #480

mhwelander · 2020-06-16T14:19:50Z

Client constructor parameters page.

Fixed some typos

…client-constructor

content/03-reference/01-tools-and-interfaces/02-prisma-client/02-constructor.mdx

…02-constructor.mdx Co-authored-by: Tim Suchanek <Tim.Suchanek@gmail.com>

Jolg42 · 2020-06-17T14:29:29Z

Just a random question...

Netlify says here in GitHub Deploy preview ready but this page is blank https://deploy-preview-480--prisma2.netlify.app/docs/reference/tools-and-interfaces/prisma-client

So it's not possible to preview the PR I guess?

mhwelander · 2020-06-17T15:01:53Z

@Jolg42 We have a bit of an issue with the /docs subdirectory - if you remove it, you can see the page: https://deploy-preview-480--prisma2.netlify.app/reference/tools-and-interfaces/prisma-client/

Jolg42 · 2020-06-17T15:41:16Z

Ok so here it's https://deploy-preview-480--prisma2.netlify.app/reference/tools-and-interfaces/prisma-client/constructor/ and it works thanks <3

Jolg42 · 2020-06-17T15:47:22Z

Spotted small things @mhwelander

Replace

prisma.schema by schema.prisma
Define a datasources by Define a datasource
Weird indentation here

…2-docs into client-constructor

mhwelander · 2020-06-18T08:45:26Z

Fixed - thank you! I'll wait for an update on whether the format of datasources will change.

content/03-reference/01-tools-and-interfaces/02-prisma-client/02-constructor.mdx

…02-constructor.mdx

Jolg42 · 2020-06-18T10:43:23Z

I broke something and fixed it but in the end the indentation looks better 😄

content/03-reference/01-tools-and-interfaces/02-prisma-client/02-constructor.mdx

janpio

Waiting for prisma/prisma#2801

content/03-reference/01-tools-and-interfaces/02-prisma-client/02-constructor.mdx

janpio · 2020-06-19T11:34:56Z

content/03-reference/01-tools-and-interfaces/02-prisma-client/02-constructor.mdx

+   })
+   ```
+
+> **Note**: If you define multiple datasources in `schema.prisma`, Prisma defaults to the first entry.


Why is that? Do we not define which one it should be applied to by using my_database?

cc @timsuchanek

There was a enabled property in the schema before that got removed (never saw it, just the remains)

What is the connection to this comment? Should it not use the datasource with the name you supply above, my_database in this example?

This is actually touching on undefined behavior, I think the Note is correct, but we need to fix that.
Even though you provide a specific datasource as a constructor arg, it could even be, that in our current implementation, it might not be used, if it's not the first datasource in the schema.
We don't have tests for that and didn't define this behavior clearly yet, but should definitely do that asap.

…02-constructor.mdx Co-authored-by: Jan Piotrowski <piotrowski+github@gmail.com>

Jolg42 · 2020-06-24T13:39:29Z

@janpio I think you can unblock that PR now 😃

janpio

One comment left for the Note, rest looks good.

Jolg42 · 2020-06-30T15:39:30Z

Yeah 🎊 😄

* Added illustrations Fixed some typos * Client constructor page * Constructor docs * Fixed index * Added # to page * Update content/03-reference/01-tools-and-interfaces/02-prisma-client/02-constructor.mdx Co-authored-by: Tim Suchanek <Tim.Suchanek@gmail.com> * Joël fixes * Update content/03-reference/01-tools-and-interfaces/02-prisma-client/02-constructor.mdx * Update 02-constructor.mdx * Update content/03-reference/01-tools-and-interfaces/02-prisma-client/02-constructor.mdx Co-authored-by: Jan Piotrowski <piotrowski+github@gmail.com> Co-authored-by: Tim Suchanek <Tim.Suchanek@gmail.com> Co-authored-by: Joël Galeran <Jolg42@users.noreply.github.com> Co-authored-by: Jan Piotrowski <piotrowski+github@gmail.com>

* Added illustrations Fixed some typos * Style guide wording * Link fixes * Enum binary * Engine binaries * Update content/02-understand-prisma/05-under-the-hood.mdx * Update content/02-understand-prisma/05-under-the-hood.mdx * Update content/02-understand-prisma/05-under-the-hood.mdx Co-authored-by: Jan Piotrowski <piotrowski+github@gmail.com> * Update content/02-understand-prisma/05-under-the-hood.mdx Co-authored-by: Jan Piotrowski <piotrowski+github@gmail.com> * Update content/02-understand-prisma/05-under-the-hood.mdx Co-authored-by: Jan Piotrowski <piotrowski+github@gmail.com> * Update content/02-understand-prisma/05-under-the-hood.mdx Co-authored-by: Jan Piotrowski <piotrowski+github@gmail.com> * Update content/02-understand-prisma/05-under-the-hood.mdx Co-authored-by: Jan Piotrowski <piotrowski+github@gmail.com> * Client constructor (#480) * Added illustrations Fixed some typos * Client constructor page * Constructor docs * Fixed index * Added # to page * Update content/03-reference/01-tools-and-interfaces/02-prisma-client/02-constructor.mdx Co-authored-by: Tim Suchanek <Tim.Suchanek@gmail.com> * Joël fixes * Update content/03-reference/01-tools-and-interfaces/02-prisma-client/02-constructor.mdx * Update 02-constructor.mdx * Update content/03-reference/01-tools-and-interfaces/02-prisma-client/02-constructor.mdx Co-authored-by: Jan Piotrowski <piotrowski+github@gmail.com> Co-authored-by: Tim Suchanek <Tim.Suchanek@gmail.com> Co-authored-by: Joël Galeran <Jolg42@users.noreply.github.com> Co-authored-by: Jan Piotrowski <piotrowski+github@gmail.com> * Fixes * Fixes * Fixes Co-authored-by: Joël Galeran <Jolg42@users.noreply.github.com> Co-authored-by: Jan Piotrowski <piotrowski+github@gmail.com> Co-authored-by: Tim Suchanek <Tim.Suchanek@gmail.com>

mhwelander added 10 commits May 26, 2020 17:20

Added illustrations

447b005

Fixed some typos

Merge branch 'master' of https://github.com/prisma/prisma2-docs

50e83b1

Merge branch 'master' of https://github.com/prisma/prisma2-docs

976c04a

Client constructor page

0c837c5

Merge branch 'master' of https://github.com/prisma/prisma2-docs into …

ffd6b85

…client-constructor

Merge branch 'master' of https://github.com/prisma/prisma2-docs into …

b7bf79a

…client-constructor

Constructor docs

46aff4e

Fixed index

b5f3fb5

Added # to page

00d6b04

Merge branch 'master' of https://github.com/prisma/prisma2-docs into …

ee2a7d3

…client-constructor

janpio reviewed Jun 16, 2020

View reviewed changes

content/03-reference/01-tools-and-interfaces/02-prisma-client/02-constructor.mdx Outdated Show resolved Hide resolved

mhwelander linked an issue Jun 17, 2020 that may be closed by this pull request

Allow datasource credentials to be passed by client #446

Closed

timsuchanek reviewed Jun 17, 2020

View reviewed changes

content/03-reference/01-tools-and-interfaces/02-prisma-client/02-constructor.mdx Outdated Show resolved Hide resolved

Update content/03-reference/01-tools-and-interfaces/02-prisma-client/…

553b4a2

…02-constructor.mdx Co-authored-by: Tim Suchanek <Tim.Suchanek@gmail.com>

mhwelander added 2 commits June 18, 2020 10:43

Joël fixes

ad65ea7

Merge branch 'client-constructor' of https://github.com/prisma/prisma…

17eec52

…2-docs into client-constructor

Jolg42 reviewed Jun 18, 2020

View reviewed changes

content/03-reference/01-tools-and-interfaces/02-prisma-client/02-constructor.mdx Outdated Show resolved Hide resolved

Jolg42 added 2 commits June 18, 2020 12:35

Update content/03-reference/01-tools-and-interfaces/02-prisma-client/…

1309e18

…02-constructor.mdx

Update 02-constructor.mdx

30b9a55

janpio mentioned this pull request Jun 18, 2020

Clean up datasources in Prisma Client constructor parameters prisma/prisma#2801

Closed

rahul3v suggested changes Jun 18, 2020

View reviewed changes

content/03-reference/01-tools-and-interfaces/02-prisma-client/02-constructor.mdx Outdated Show resolved Hide resolved

janpio requested changes Jun 18, 2020

View reviewed changes

janpio self-requested a review June 19, 2020 11:32

janpio reviewed Jun 19, 2020

View reviewed changes

content/03-reference/01-tools-and-interfaces/02-prisma-client/02-constructor.mdx Outdated Show resolved Hide resolved

janpio reviewed Jun 19, 2020

View reviewed changes

Update content/03-reference/01-tools-and-interfaces/02-prisma-client/…

e806297

…02-constructor.mdx Co-authored-by: Jan Piotrowski <piotrowski+github@gmail.com>

mhwelander added the docs Documentation creation, updates or corrections label Jun 24, 2020

janpio self-requested a review June 24, 2020 18:09

janpio approved these changes Jun 24, 2020

View reviewed changes

mhwelander merged commit c177960 into master Jun 30, 2020

mhwelander deleted the client-constructor branch June 30, 2020 14:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Client constructor #480

Client constructor #480

mhwelander commented Jun 16, 2020

Jolg42 commented Jun 17, 2020

mhwelander commented Jun 17, 2020

Jolg42 commented Jun 17, 2020 •

edited

Jolg42 commented Jun 17, 2020

mhwelander commented Jun 18, 2020

Jolg42 commented Jun 18, 2020

janpio left a comment

janpio Jun 19, 2020

janpio Jun 19, 2020

Jolg42 Jun 19, 2020

janpio Jun 24, 2020

timsuchanek Jun 25, 2020

Jolg42 commented Jun 24, 2020

janpio left a comment

Jolg42 commented Jun 30, 2020

Client constructor #480

Client constructor #480

Conversation

mhwelander commented Jun 16, 2020

Jolg42 commented Jun 17, 2020

mhwelander commented Jun 17, 2020

Jolg42 commented Jun 17, 2020 • edited

Jolg42 commented Jun 17, 2020

mhwelander commented Jun 18, 2020

Jolg42 commented Jun 18, 2020

janpio left a comment

Choose a reason for hiding this comment

janpio Jun 19, 2020

Choose a reason for hiding this comment

janpio Jun 19, 2020

Choose a reason for hiding this comment

Jolg42 Jun 19, 2020

Choose a reason for hiding this comment

janpio Jun 24, 2020

Choose a reason for hiding this comment

timsuchanek Jun 25, 2020

Choose a reason for hiding this comment

Jolg42 commented Jun 24, 2020

janpio left a comment

Choose a reason for hiding this comment

Jolg42 commented Jun 30, 2020

Jolg42 commented Jun 17, 2020 •

edited