Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Serverless initiative): test Prisma error messages in unsupported systems #3332

Open
4 of 5 tasks
jkomyno opened this issue Dec 21, 2022 · 3 comments
Open
4 of 5 tasks
Assignees
Labels
kind/feature A request for a new feature. team/client Issue for team Client. team/schema Issue for team Schema. topic: serverless

Comments

@jkomyno
Copy link
Contributor

jkomyno commented Dec 21, 2022

Prisma may throw a number of different error messages when loading the Prisma Engines fails. Although we already attempt to provide meaningful user-facing explanations of what went wrong, we should strive to be more precise.

We should thus add some ecosystem-tests that try to install and run Prisma on scenarios where we know it would fail.

Relevant unsupported systems we should test the new conditional error messages on:

@jkomyno jkomyno added team/schema Issue for team Schema. team/client Issue for team Client. topic: serverless labels Dec 21, 2022
@janpio janpio added the kind/feature A request for a new feature. label Dec 21, 2022
@janpio
Copy link
Member

janpio commented Dec 21, 2022

This is probably not something that should be run with every version. But it totally makes sense as a manual thing we can run.

@mcbethio
Copy link

mcbethio commented Feb 4, 2023

Folks, can we fix the milestone on this issue please. 4.9.0 has already sailed.

@jkomyno jkomyno modified the milestones: 4.9.0, 4.10.0 Feb 7, 2023
@jkomyno
Copy link
Contributor Author

jkomyno commented Feb 7, 2023

Note: we tried assertions in prisma/prisma#17762, but they didn't make it to the release due to bundling issues with jest.spyOn. We did manual testing using the setup from ecosystem-tests / docker on an integration release for the time being.

@mcbethio mcbethio removed this from the 4.10.0 milestone Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature A request for a new feature. team/client Issue for team Client. team/schema Issue for team Schema. topic: serverless
Projects
None yet
Development

No branches or pull requests

4 participants