feat: e2e Docker OS support #3341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkomyno
force-pushed
the
feat/e2e-docker-os-support
branch
from
9ee1897
to
e6ff453
Compare
jkomyno
force-pushed
the
feat/e2e-docker-os-support
branch
from
0e67040
to
a241abc
Compare
jkomyno
requested review from
janpio,
millsp,
aqrln,
SevInf and
danstarns
as code owners
Jolg42
approved these changes
Jan 3, 2023
janpio
reviewed
Jan 3, 2023
| - OpenSSL location: `/lib/libssl.so.1.1` | ||
| - Binary target: `linux-musl` | ||
|
|
||
| Although Linux Alpine 3.17+ upgraded to OpenSSL 3, this example uses the `openssl1.1-compat` package to install OpenSSL 1.1. |
There was a problem hiding this comment.
Is the folder name then not incorrect/misleading?
janpio
reviewed
Jan 3, 2023
| # Update system dependencies. | ||
| # OpenSSL is missing in the base image, so we install it | ||
| RUN apt-get update -y \ | ||
| && apt-get install -y openssl |
There was a problem hiding this comment.
Does this reliably pin to OpenSSL 1.1?
janpio
reviewed
Jan 3, 2023
| @@ -0,0 +1,17 @@ | |||
| { | |||
| "name": "@prisma/debian-buster-amd64-openssl-undefined", | |||
There was a problem hiding this comment.
Long term Prisma should throw an installation when no OpenSSL is found I assume instead of failing later?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #3340, pointing to the
devbranch.Contributes to prisma/prisma#14017, #3332, prisma/prisma#16962, prisma/docs#4303
This PR adds Dockerised OS Support tests for in the
./dockerfolder. In particular, it tries to run Prisma Client (both binary and library) in the following systems:Additionally, for each Dockerised system, we assert the
binaryTargetselected by Prisma (i.e., theCurrent platformvalue inprisma -v). If a major Docker image suddenly introduces a new OpenSSL version we don't support, or switches to another architecture by default, we will receive a Slack notification.Multiarchitecture support (
amd64,arm64) works via QEMU (docker/setup-qemu-action@v2) and Docker Buildx (docker/setup-buildx-action@v2).Review Helpers
.yaml,.shNo extension.md.md,.yaml,.sh,No extensionTODOs
From these tests, I have opened the following issues:
We should:
debian-latest-arm64-openssl-1.1.xto the Docker test pipeline once https://github.com/prisma/prisma-private/issues/205 is solved. Done in: ci: add debian-latest-arm64-openssl-1.1.x to docker workflow #3342dockerworkflow only once per day_fail-debian-buster-amd64-openssl-1.1.x