-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: docker os support followup #3343
Conversation
It increases the latency and the context size being shared with Docker, without actually being used.
b03785e
to
9678bff
Compare
2a18c4d
to
e8e5393
Compare
1e0cc9d
to
a5737bf
Compare
a5737bf
to
69efa55
Compare
Hmm, just noticed this in the CI output of one of the
We should double check if that is normal of if the moving of the install command potentially impacted this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests themselves look great and show nicely how Prisma currently fails in certain environments 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, this one is not happy and fails to early and for an unexpected reason: https://github.com/prisma/ecosystem-tests/actions/runs/3849578290/jobs/6558754809#step:7:97
Nice catch, I hadn't updated all the paths passed to |
1fcdc40
to
3498171
Compare
ab001e8
to
05077f7
Compare
docker-unsupported/alpine-3.16-arm64-openssl-1.1.x-with-libc/README.md
Outdated
Show resolved
Hide resolved
docker-unsupported/alpine-3.17-arm64-openssl-3.0.x-with-libc/README.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Jan Piotrowski <piotrowski+github@gmail.com>
Co-authored-by: Jan Piotrowski <piotrowski+github@gmail.com>
Note: |
This PR:
docker
tests:debian-stretch-amd64-openssl-1.1.x
distroless-bullseye-amd64-openssl-1.1.x
(currently failing although I have used it to solve Library may be corrupt (missinglibz.so.1
) when using distroless Docker images prisma#16205, low priority, we can fix it in a later PR)redhat-ubi9-amd64-openssl-3.0.x
docker-unsupported
tests, which are stored indocker/_fail/*
and are expected to failalpine-3.16-arm64-openssl-1.1.x
alpine-3.16-arm64-openssl-1.1.x-with-libc
alpine-3.17-arm64-openssl-3.0.x
alpine-3.17-arm64-openssl-3.0.x-with-libc
debian-buster-amd64-openssl-1.1.x
(noopenssl
installed)distroless-bullseye-amd64-openssl-1.1.x
(nolibz
installed)It also closes prisma/prisma#14017.
Review Filters
.yaml
,.sh
No extension
.md
.md
,.yaml
,.sh
,No extension