Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: docker os support followup #3343

Merged
merged 43 commits into from
Jan 11, 2023
Merged

feat: docker os support followup #3343

merged 43 commits into from
Jan 11, 2023

Conversation

jkomyno
Copy link
Contributor

@jkomyno jkomyno commented Jan 4, 2023

This PR:

  • adds new docker tests:
  • adds new docker-unsupported tests, which are stored in docker/_fail/* and are expected to fail
    • alpine-3.16-arm64-openssl-1.1.x
    • alpine-3.16-arm64-openssl-1.1.x-with-libc
    • alpine-3.17-arm64-openssl-3.0.x
    • alpine-3.17-arm64-openssl-3.0.x-with-libc
    • debian-buster-amd64-openssl-1.1.x (no openssl installed)
    • distroless-bullseye-amd64-openssl-1.1.x (no libz installed)
  • use yarn on the host system (i.e., not Docker) only after the Docker test has run
  • polishes minor details / comments

It also closes prisma/prisma#14017.

Review Filters

@jkomyno jkomyno force-pushed the feat/docker-os-support-followup branch from b03785e to 9678bff Compare January 5, 2023 12:09
@jkomyno jkomyno force-pushed the feat/docker-os-support-followup branch from 2a18c4d to e8e5393 Compare January 5, 2023 12:15
@Jolg42 Jolg42 added this to the 4.9.0 milestone Jan 5, 2023
@jkomyno jkomyno force-pushed the feat/docker-os-support-followup branch from 1e0cc9d to a5737bf Compare January 5, 2023 15:41
@jkomyno jkomyno force-pushed the feat/docker-os-support-followup branch from a5737bf to 69efa55 Compare January 5, 2023 15:43
docker-failing/README.md Outdated Show resolved Hide resolved
@janpio
Copy link
Member

janpio commented Jan 5, 2023

Hmm, just noticed this in the CI output of one of the docker-failing runs:
https://github.com/prisma/ecosystem-tests/actions/runs/3849578290/jobs/6558754456#step:7:70

+ npx prisma db push --accept-data-loss --skip-generate --schema=docker-failing/alpine-3.16-arm64-openssl-1.1.x/prisma/schema.prisma
npx prisma db push --accept-data-loss --skip-generate --schema=docker-failing/alpine-3.16-arm64-openssl-1.1.x/prisma/schema.prisma
npm WARN exec The following package was not found and will be installed: prisma@4.8.1

We should double check if that is normal of if the moving of the install command potentially impacted this.

Copy link
Member

@janpio janpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests themselves look great and show nicely how Prisma currently fails in certain environments 👍

Copy link
Member

@janpio janpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, this one is not happy and fails to early and for an unexpected reason: https://github.com/prisma/ecosystem-tests/actions/runs/3849578290/jobs/6558754809#step:7:97

@jkomyno
Copy link
Contributor Author

jkomyno commented Jan 5, 2023

Actually, this one is not happy and fails to early and for an unexpected reason: https://github.com/prisma/ecosystem-tests/actions/runs/3849578290/jobs/6558754809#step:7:97

Nice catch, I hadn't updated all the paths passed to docker build. It's fixed now

@jkomyno jkomyno force-pushed the feat/docker-os-support-followup branch from 1fcdc40 to 3498171 Compare January 5, 2023 21:57
@jkomyno jkomyno force-pushed the feat/docker-os-support-followup branch from ab001e8 to 05077f7 Compare January 11, 2023 17:54
@janpio janpio self-requested a review January 11, 2023 18:13
jkomyno and others added 2 commits January 11, 2023 19:26
Co-authored-by: Jan Piotrowski <piotrowski+github@gmail.com>
Co-authored-by: Jan Piotrowski <piotrowski+github@gmail.com>
@jkomyno
Copy link
Contributor Author

jkomyno commented Jan 11, 2023

Note: test / platforms-serverless-vercel is failing due to prisma/prisma#17241

@jkomyno jkomyno merged commit c3eb3d2 into dev Jan 11, 2023
@jkomyno jkomyno deleted the feat/docker-os-support-followup branch January 11, 2023 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create CI worker without a proper openssl or libc installation to improve snapshot testing suite
3 participants