Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: remove publish auto commit #242

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

Jolg42
Copy link
Member

@Jolg42 Jolg42 commented Nov 5, 2021

It's actually not needed and causes noise as a failure of the workflow when 2 publish happen "at the same time"
https://github.com/prisma/engines-wrapper/runs/3748154135?check_suite_focus=true

Maybe we should set the version to 0.0.0 in git now

@janpio
Copy link
Member

janpio commented Nov 5, 2021

Hm, isn't this commit how we connect the engines hash to the Npm version it got published as?
How would I figure out which code version a released version contains?
(The commit contains both the actual code change, and the version increase and calculation)

@Jolg42
Copy link
Member Author

Jolg42 commented Nov 5, 2021

This commit is purely for git history which is not needed.

We could use tags here if we wanted to track the state of the codebase when a release happens, that could be cleaner.

@janpio
Copy link
Member

janpio commented Nov 5, 2021

Right now this commit is a record of the release, and the connection of the engine hash to the @prisma/engines version that is published to Npm. Let's investigate if that could also be provided by tags.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants