Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential pipeline 馃敟 of language-tools with versioning change of @prisma/engines #1184

Closed
Jolg42 opened this issue Jun 23, 2022 · 2 comments 路 Fixed by #1191
Closed

Potential pipeline 馃敟 of language-tools with versioning change of @prisma/engines #1184

Jolg42 opened this issue Jun 23, 2022 · 2 comments 路 Fixed by #1191
Assignees
Labels
kind/tech A technical change. team/client Issue for team Client. team/schema Issue for team Schema.
Milestone

Comments

@Jolg42
Copy link
Member

Jolg42 commented Jun 23, 2022

Related to the PR prisma/prisma#13769

We found that the language-tools pipeline relies on the @prisma/engines version to resolve the same version from @prisma/prisma-fmt-wasm
Which currently looks like 3.16.0-43.81a0ee489e5f8c8ce98440028ea9050092430503 (engine hash format)

// engines hash
const engineVersion = prismaCLIDeps['@prisma/engines'] // 2.26.0-23.9b816b3aa13cc270074f172f30d6eda8a8ce867d
const sha = engineVersion.split('.')[3]
let languageServerPackageJson = getPackageJsonContent({
path: languageServerPackageJsonPath,
})
languageServerPackageJson['prisma']['enginesVersion'] = sha
// engines version
languageServerPackageJson['dependencies']['@prisma/prisma-fmt-wasm'] =
engineVersion

@prisma/engines version should change to the prisma monorepo version like 3.16.0-dev.93 (dev) or 3.16.0 (stable) which is missing the engine hash.

We could maybe solve this by adding the @prisma/engines-version dependency to the prisma CLI package.json

@Jolg42 Jolg42 added kind/tech A technical change. team/schema Issue for team Schema. team/client Issue for team Client. labels Jun 23, 2022
@Jolg42 Jolg42 added the process/candidate Candidate for next Milestone. label Jun 24, 2022
@floelhoeffel floelhoeffel removed the process/candidate Candidate for next Milestone. label Jun 29, 2022
@millsp
Copy link
Member

millsp commented Jun 29, 2022

We can use import { enginesVersion } from '@prisma/engines', which gives the sha.

@millsp millsp added this to the 4.1.0 milestone Jun 29, 2022
@Jolg42
Copy link
Member Author

Jolg42 commented Jun 29, 2022

Yes! Let's try that later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/tech A technical change. team/client Issue for team Client. team/schema Issue for team Schema.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants