Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use @prisma/engines to determine engines hash #1191

Merged
merged 2 commits into from
Jul 1, 2022

Conversation

Jolg42
Copy link
Member

@Jolg42 Jolg42 commented Jun 30, 2022

To merge after prisma/prisma#13769

Closes #1184

@Jolg42 Jolg42 added this to the 4.1.0 milestone Jun 30, 2022
@Jolg42 Jolg42 requested a review from millsp June 30, 2022 09:02
@github-actions
Copy link

github-actions bot commented Jun 30, 2022

🤖 Pull request artifacts

file commit
pr1191-prisma.vsix 2eae324

github-actions bot added a commit that referenced this pull request Jun 30, 2022
@github-actions
Copy link

@Jolg42 Jolg42 requested a review from jkomyno June 30, 2022 09:04
Comment on lines 71 to 82
// CLI deps
const { stdout } = await execa('npm', [
'show',
`prisma@${newPrismaVersion}`,
'dependencies',
])
// Find the version needed for `@prisma/prisma-fmt-wasm`
// Let's look into the `package.json` of the `@prisma/engines` package
// and take it from `@prisma/engines-version`
const { stdout } = await execa('npm', ['show', `@prisma/engines@${newPrismaVersion}`, 'dependencies'])
const cleaned = stdout.replace(/'/g, '"')
let prismaCLIDeps = JSON.parse(cleaned)
let npmInfoOutput = JSON.parse(cleaned)
const engineVersion = npmInfoOutput['@prisma/engines-version'] // 2.26.0-23.9b816b3aa13cc270074f172f30d6eda8a8ce867d
const engineSha = engineVersion.split('.')[3]

// engines hash
const engineVersion = prismaCLIDeps['@prisma/engines'] // 2.26.0-23.9b816b3aa13cc270074f172f30d6eda8a8ce867d
const sha = engineVersion.split('.')[3]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is the change

Co-authored-by: Jan Piotrowski <piotrowski+github@gmail.com>
github-actions bot added a commit that referenced this pull request Jun 30, 2022
@Jolg42 Jolg42 self-assigned this Jul 1, 2022
@Jolg42 Jolg42 merged commit 98eae1d into main Jul 1, 2022
@Jolg42 Jolg42 deleted the joel/use-prisma/engines-pkg-for-version branch July 1, 2022 12:35
@Jolg42
Copy link
Member Author

Jolg42 commented Jul 1, 2022

Needed a small fix 5dff75a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Potential pipeline 🔥 of language-tools with versioning change of @prisma/engines
2 participants