Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add VS Code quick fix / code action to replace SetDefault with NoAction when provider = "mysql" and relationMode = "foreignKeys" | default #1286

Closed
1 of 2 tasks
jkomyno opened this issue Nov 14, 2022 · 0 comments · Fixed by prisma/prisma-engines#4210
Closed
1 of 2 tasks

Add VS Code quick fix / code action to replace SetDefault with NoAction when provider = "mysql" and relationMode = "foreignKeys" | default #1286

jkomyno opened this issue Nov 14, 2022 · 0 comments · Fixed by prisma/prisma-engines#4210
Labels
kind/improvement An improvement to existing feature and code. team/schema Issue for team Schema. topic: code action
Projects
🌐 Language Tools Issue Categorization
Milestone
5.3.0

Comments

@jkomyno
Copy link
Contributor

jkomyno commented Nov 14, 2022 •
edited by Druue

After prisma/prisma#16259 is done, and only for provider = "mysql" and relationMode = "foreignKeys" (or no relationMode attribute at all), we should provide a code action that:
@jkomyno jkomyno added kind/improvement An improvement to existing feature and code. team/schema Issue for team Schema. topic: code action labels Nov 14, 2022
@janpio janpio changed the title Add VS Code quick action to replace SetDefault with NoAction when provider = "mysql" and relationMode = "foreignKeys" | default Add VS Code quick fic / code action to replace SetDefault with NoAction when provider = "mysql" and relationMode = "foreignKeys" | default Nov 23, 2022
@janpio janpio changed the title Add VS Code quick fic / code action to replace SetDefault with NoAction when provider = "mysql" and relationMode = "foreignKeys" | default Add VS Code quick fix / code action to replace SetDefault with NoAction when provider = "mysql" and relationMode = "foreignKeys" | default Nov 23, 2022
@Druue Druue added this to Quickfix / CodeAction in 🌐 Language Tools Issue Categorization Dec 1, 2022
Druue added a commit to prisma/prisma-engines that referenced this issue Sep 6, 2023
@Druue
Add quickfix to migrate SetDefault -> NoAction
6f60578 
when using relationMode=foreignkeys on mysql

closes prisma/language-tools#1286
@Druue Druue mentioned this issue Sep 6, 2023
Merged
@Jolg42 Jolg42 added this to the 5.3.0 milestone Sep 7, 2023
Druue added a commit to prisma/prisma-engines that referenced this issue Sep 11, 2023
@Druue
feat(fmt): qf SetDefault -> NoAction on mysql w/ foreignkeys (#4210)
e90b936 
* Add quickfix to migrate `SetDefault` -> `NoAction`
when using `relationMode = "foreignkeys"` on mysql

closes prisma/language-tools#1286
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/improvement An improvement to existing feature and code. team/schema Issue for team Schema. topic: code action
Projects
🌐 Language Tools Issue Categorization
Quickfix / CodeAction
Milestone
5.3.0
Development

Successfully merging a pull request may close this issue.

feat(fmt): qf SetDefault -> NoAction on mysql w/ foreignkeys prisma/prisma-engines
2 participants
@Jolg42 @jkomyno