Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(fmt): qf SetDefault -> NoAction on mysql w/ foreignkeys #4210

Merged
merged 3 commits into from
Sep 11, 2023
Merged

feat(fmt): qf SetDefault -> NoAction on mysql w/ foreignkeys #4210

merged 3 commits into from
Sep 11, 2023

Conversation

Druue
Copy link
Contributor

@Druue Druue commented Sep 6, 2023

Screen.Recording.2023-09-06.at.18.26.39.mov

closes prisma/language-tools#1286

@Druue
Add quickfix to migrate SetDefault -> NoAction
6f60578 
when using relationMode=foreignkeys on mysql

closes prisma/language-tools#1286
@Druue Druue added this to the 5.3.0 milestone Sep 6, 2023
@Druue Druue requested a review from a team as a code owner September 6, 2023 16:28
@Druue Druue requested a review from tomhoule September 6, 2023 16:28
@codspeed-hq
Copy link

codspeed-hq bot commented Sep 6, 2023 •
edited

CodSpeed Performance Report

Merging #4210 will not alter performance

Comparing impr/qf-mysql-setdefault (59bc623) with main (7fec122)

Summary

✅ 11 untouched benchmarks

tomhoule
tomhoule approved these changes Sep 7, 2023
View reviewed changes
Copy link
Contributor

@tomhoule tomhoule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and clean 💯

@janpio
Copy link
Member

janpio commented Sep 7, 2023

Is the motivation for the quick fix visible some way?

@Druue Druue merged commit e90b936 into main Sep 11, 2023
54 checks passed
@Druue Druue deleted the impr/qf-mysql-setdefault branch September 11, 2023 12:11
@janpio
Copy link
Member

janpio commented Sep 11, 2023

(It is, as a validation warning)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkomyno jkomyno jkomyno approved these changes

@tomhoule tomhoule tomhoule approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.3.0
4 participants
@Druue @janpio @jkomyno @tomhoule