Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ls): suggest SQL Server index clustered and values #1175

Merged
merged 6 commits into from
Jun 21, 2022

Conversation

@Jolg42 Jolg42 added this to the 4.0.x milestone Jun 21, 2022
@github-actions
Copy link

github-actions bot commented Jun 21, 2022

🤖 Pull request artifacts

file commit
pr1175-prisma.vsix caa0100

github-actions bot added a commit that referenced this pull request Jun 21, 2022
@github-actions
Copy link

@Jolg42 Jolg42 marked this pull request as ready for review June 21, 2022 12:52
github-actions bot added a commit that referenced this pull request Jun 21, 2022
github-actions bot added a commit that referenced this pull request Jun 21, 2022
},
},
]

export function givenFieldAttributeParams(
fieldAttribute: '@unique' | '@id' | '@@index',
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 @@index is a block attribute

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jolg42
Copy link
Member Author

Jolg42 commented Jun 21, 2022

Note: Implemented without the Only one id/unique/index can be clustered per model rule, validation makes sure it is enforced with Error parsing attribute "@@unique": A model can only hold one clustered index.

@Jolg42
Copy link
Member Author

Jolg42 commented Jun 21, 2022

Reviewed on Zoom with Alberto

github-actions bot added a commit that referenced this pull request Jun 21, 2022
github-actions bot added a commit that referenced this pull request Jun 21, 2022
@Jolg42 Jolg42 merged commit b1c9c47 into main Jun 21, 2022
@Jolg42 Jolg42 deleted the joel/sql-server-clustered branch June 21, 2022 14:59
Jolg42 added a commit that referenced this pull request Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Completion for SQL Server Index Clustering
1 participant