fix(completion): suggest @id for enum and ignore comments #1192
Conversation
🤖 Pull request artifacts
|
| } | ||
|
|
||
| const modelOrEnum = getModelOrTypeOrEnumBlock(fieldType, lines) | ||
| const isAtIdAllowed = fieldType === 'Int' || fieldType === 'String' || modelOrEnum?.type === 'enum' |
There was a problem hiding this comment.
I think we allow ids on basically everything except relation fields, so it doesn't need to be restricted to Int and String. These are terrible, terrible ideas of course, but you can have id DateTime @id or id Float @id.
There was a problem hiding this comment.
So it's actually ok to not suggest it then 😄
There was a problem hiding this comment.
That is an interesting fundametnal discussion: Do we want to suggest all the things that validate, or only the things we want to encourage?
There was a problem hiding this comment.
With id DateTime @id id Float @id it sounds very bad
Maybe we should still suggest it because a handful of people would actually know how to use that. But then it's a "foot gun" for most people, I guess?
There was a problem hiding this comment.
Update per discussion on slack:
It is possible to display hints / tooltips
Therefore, I am of the mind that we enable @id for all fields that are already supported in engines. Then we can work on adding these tooltips for usage of @id on fields that wouldn't be recommended with an explanation as to why.
closes #1084
Added
@idsuggestion after an enum