Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change "criteria" to "criterion" when used in singular form #1226

Merged
merged 2 commits into from Dec 9, 2022

Conversation

DePasqualeOrg
Copy link
Contributor

@DePasqualeOrg DePasqualeOrg commented Aug 14, 2022

closes #1321

@CLAassistant
Copy link

CLAassistant commented Aug 14, 2022

CLA assistant check
All committers have signed the CLA.

@janpio
Copy link
Member

janpio commented Aug 15, 2022

Ohoh, we might have that in a few more places 😆
https://github.com/prisma/prisma-engines/search?q=a+unique+criteria

@Jolg42 Jolg42 added this to the 4.3.0 milestone Aug 15, 2022
Copy link
Member

@Jolg42 Jolg42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This would need to first be changed in the prisma-engines repository where the error comes from (see Jan's link)

@Druue
Copy link
Contributor

Druue commented Dec 9, 2022

Good to go!

@Druue Druue requested a review from Jolg42 December 9, 2022 13:10
@Jolg42 Jolg42 merged commit 5361b83 into prisma:main Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to use correct form of criteri(a/on)
5 participants