Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: dim @ignore fields and @@ignore models #1285

Merged
merged 7 commits into from Nov 15, 2022
Merged

feat: dim @ignore fields and @@ignore models #1285

merged 7 commits into from Nov 15, 2022

Conversation

Druue
Copy link
Contributor

@Druue Druue commented Nov 14, 2022

closes #689

@Druue Druue added kind/improvement An improvement to existing feature and code. topic: language server team/schema Issue for team Schema. labels Nov 14, 2022
@Druue Druue added this to the 4.7.0 milestone Nov 14, 2022
@Druue Druue requested a review from Jolg42 November 14, 2022 16:34
@Druue Druue self-assigned this Nov 14, 2022
@github-actions
Copy link

github-actions bot commented Nov 14, 2022 •
edited

🤖 Pull request artifacts

file commit
pr1285-prisma.vsix 17f36ab

github-actions bot added a commit that referenced this pull request Nov 14, 2022
@github-actions
Upload pr1285-prisma.vsix (87301)
8f38714 
Pull request: #1285
Commit: 87301c1
@github-actions
Copy link

Try this extension build via GitPod

@Druue
Copy link
Contributor Author

Druue commented Nov 14, 2022

This results in the following look:
image
image
image

@Jolg42 Jolg42 mentioned this pull request Nov 14, 2022
Closed
@Jolg42
Copy link
Member

Jolg42 commented Nov 14, 2022 •
edited

This looks great! Maybe we can slightly tweak the message. (suggestion coming soon)
Trying from Gitpod shows
Screenshot 2022-11-14 at 17 49 48

@Jolg42
Copy link
Member

Jolg42 commented Nov 14, 2022

I think we could add some tests in https://github.com/prisma/language-tools/blob/main/packages/language-server/src/__test__/linting.test.ts for both diagnostics

@Druue @Jolg42
Updated diagnostic hint for (@)@ignored
dc9e49c 
Co-authored-by: Joël Galeran <Jolg42@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Nov 14, 2022
@github-actions
Upload pr1285-prisma.vsix (dc9e4)
3beecf2 
Pull request: #1285
Commit: dc9e49c
github-actions bot added a commit that referenced this pull request Nov 15, 2022
@github-actions
Upload pr1285-prisma.vsix (425e7)
8c05ebd 
Pull request: #1285
Commit: 425e756
github-actions bot added a commit that referenced this pull request Nov 15, 2022
@github-actions
Upload pr1285-prisma.vsix (ed67f)
13cb279 
Pull request: #1285
Commit: ed67f80
github-actions bot added a commit that referenced this pull request Nov 15, 2022
@github-actions
Upload pr1285-prisma.vsix (1831f)
f474439 
Pull request: #1285
Commit: 1831f38
@Jolg42 Jolg42 changed the title feat: dim ignored feat: dim @ignore fields and @@ignore models Nov 15, 2022
@Druue Druue requested review from janpio and Jolg42 November 15, 2022 13:52
github-actions bot added a commit that referenced this pull request Nov 15, 2022
@github-actions
Upload pr1285-prisma.vsix (17f36)
45727a7 
Pull request: #1285
Commit: 17f36ab
Jolg42
Jolg42 approved these changes Nov 15, 2022
View reviewed changes
Copy link
Member

@Jolg42 Jolg42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Well done 🙌🏼

@Jolg42 Jolg42 merged commit 575f37f into main Nov 15, 2022
@Jolg42 Jolg42 deleted the feat/dim-ignored branch November 15, 2022 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jolg42 Jolg42 Jolg42 approved these changes

@janpio janpio Awaiting requested review from janpio

Assignees

@Druue Druue

Labels
kind/improvement An improvement to existing feature and code. team/schema Issue for team Schema. topic: language server
Projects
None yet
Milestone
4.7.0
Development

Successfully merging this pull request may close these issues.

Dim models that are @@ignored and fields that are @ignored
3 participants
@Druue @Jolg42 @janpio