Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggest @map when not already present in line #1320

Merged
merged 2 commits into from Dec 12, 2022
Merged

Suggest @map when not already present in line #1320

merged 2 commits into from Dec 12, 2022

Conversation

Druue
Copy link
Contributor

@Druue Druue commented Dec 8, 2022

  • Added test to ensure that @map is not suggested when already present in line
  • Updated another test to ensure that it does still show when already present on another line
  • Minor refactoring

closes #1079

@Druue
Fixes: #1079
a4a4850 
Added test to ensure that `@map` is not suggested when already present in line
Updated another test to ensure that it does still show when already present on another line
Minor refactoring
@github-actions
Copy link

github-actions bot commented Dec 8, 2022 •
edited

🤖 Pull request artifacts

file commit
pr1320-prisma.vsix d838939

github-actions bot added a commit that referenced this pull request Dec 8, 2022
@github-actions
Upload pr1320-prisma.vsix (a4a48)
179de40 
Pull request: #1320
Commit: a4a4850
@github-actions
Copy link

github-actions bot commented Dec 8, 2022

Try this extension build via GitPod

@Druue Druue requested a review from Jolg42 December 8, 2022 18:06
@Jolg42 Jolg42 added this to the 4.8.0 milestone Dec 9, 2022
@Druue @janpio
Update packages/language-server/src/__test__/completion.test.ts
d838939 
Co-authored-by: Jan Piotrowski <piotrowski+github@gmail.com>
github-actions bot added a commit that referenced this pull request Dec 11, 2022
@github-actions
Upload pr1320-prisma.vsix (d8389)
f80c161 
Pull request: #1320
Commit: d838939
@Druue Druue merged commit 1db4420 into main Dec 12, 2022
@Druue Druue deleted the fix/map_when_already_present branch December 12, 2022 07:56
Jolg42
Jolg42 reviewed Dec 12, 2022
View reviewed changes
packages/language-server/src/completion/completionUtils.ts
}

if (currentLine.includes('@map')) {
suggestions = suggestions.filter((suggestion) => suggestion.label !== '@map')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like we should do the same for @unique, @default(), @ignore, @relation after this PR

Jolg42
Jolg42 reviewed Dec 12, 2022
View reviewed changes
Copy link
Member

@Jolg42 Jolg42 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍🏼

It looks like we can apply the same logic for @unique, @default(), @ignore, @relation() after this PR

@Jolg42
Copy link
Member

Jolg42 commented Dec 12, 2022

Created an issue for these #1326

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janpio janpio janpio left review comments

@Jolg42 Jolg42 Jolg42 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.8.0
Development

Successfully merging this pull request may close these issues.

Auto completion suggests @map although already present
3 participants
@Druue @Jolg42 @janpio