Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ls): completion for nanoid() #1372

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

feat(ls): completion for nanoid() #1372

wants to merge 2 commits into from

Conversation

Jolg42
Copy link
Member

@Jolg42 Jolg42 commented Jan 27, 2023 •
edited

Part of: prisma/prisma#17199

⚠️ Note: we want to wait until all the work is done (see issue) before merging this.

Screenshot 2023-01-27 at 11 54 07

@Jolg42
feat(ls): completion for nanoid()
161cd39 
Part of: prisma/prisma#17199

Note: we want to wait until all the work is done (see issue) before merging this.
@Jolg42 Jolg42 requested a review from Druue January 27, 2023 10:44
@github-actions
Copy link

github-actions bot commented Jan 27, 2023 •
edited

🤖 Pull request artifacts

file commit
pr1372-prisma.vsix 206a400

github-actions bot added a commit that referenced this pull request Jan 27, 2023
@github-actions
Upload pr1372-prisma.vsix (161cd)
db504a0 
Pull request: #1372
Commit: 161cd39
@github-actions
Copy link

Try this extension build via GitPod

@Jolg42 Jolg42 mentioned this pull request Jan 27, 2023
Open
9 tasks
Druue
Druue approved these changes Jan 27, 2023
View reviewed changes
Copy link
Contributor

@Druue Druue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm c:
The only thing I'd note is that triggering autocomplete from within nanoId brings up the general completions for @default. But that I think that's unrelated and for a future check on completions 👍

github-actions bot added a commit that referenced this pull request Aug 23, 2023
@github-actions
Upload pr1372-prisma.vsix (206a4)
849d0c9 
Pull request: #1372
Commit: 206a400
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Druue Druue Druue approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Jolg42 @Druue