Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ls): no more completions for attributes that are already present #1537

Merged
merged 2 commits into from
Sep 29, 2023
Merged

fix(ls): no more completions for attributes that are already present #1537

merged 2 commits into from
Sep 29, 2023

Conversation

Druue
Copy link
Contributor

@Druue Druue commented Sep 19, 2023

fixes #1326

@Druue Druue added this to the 5.4.0 milestone Sep 19, 2023
@github-actions
Copy link

🤖 Pull request artifacts

file commit
pr1537-prisma.vsix 8051e33

github-actions bot added a commit that referenced this pull request Sep 19, 2023
@github-actions
Upload pr1537-prisma.vsix (8051e)
a5c6f31 
Pull request: #1537
Commit: 8051e33
@github-actions
Copy link

Try this extension build via GitPod

@janpio janpio changed the title fix(ls): completions for attributes that are already present fix(ls): noe more completions for attributes that are already present Sep 20, 2023
@janpio janpio changed the title fix(ls): noe more completions for attributes that are already present fix(ls): no more completions for attributes that are already present Sep 20, 2023
@Druue Druue requested review from Jolg42 and millsp September 20, 2023 13:18
Jolg42
Jolg42 approved these changes Sep 29, 2023
View reviewed changes
Copy link
Member

@Jolg42 Jolg42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement with nice tests ✨

@Jolg42 Jolg42 merged commit c0a4202 into main Sep 29, 2023
2 checks passed
@Jolg42 Jolg42 deleted the fix/ac-already-present-attributes branch September 29, 2023 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janpio janpio janpio left review comments

@Jolg42 Jolg42 Jolg42 approved these changes

@aqrln aqrln aqrln left review comments

@Weakky Weakky Weakky left review comments

@millsp millsp Awaiting requested review from millsp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.4.0
Development

Successfully merging this pull request may close these issues.

Auto-completion suggests attributes already present
5 participants
@Druue @janpio @Jolg42 @aqrln @Weakky