Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improvement(CI): add version to slack notification #261

Merged
merged 2 commits into from
Jun 22, 2020
Merged

improvement(CI): add version to slack notification #261

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c4acb6e
add version to slack notification
carmenberndt Jun 22, 2020
0433b16
fix indent
carmenberndt Jun 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
14 changes: 10 additions & 4 deletions .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ jobs:
- name: Bump versions
if: ${{ steps.check_for_updates.outputs.new_updates }}
run: yarn vsce:bump "latest"
id: bump_versions
- name: Compile
run: yarn compile
- name: Run headless e2e tests
Expand All @@ -43,7 +44,8 @@ jobs:
uses: rtCamp/action-slack-notify@v2.0.2
env:
SLACK_CHANNEL: feed-vscode
SLACK_MESSAGE: "Publishing stable failed :x:"
SLACK_TITLE: "Publishing stable failed :x:"
SLACK_MESSAGE: ${{ steps.bump_versions.outputs.version }}
SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK }}
SLACK_ICON_EMOJI: ":ship:"
SLACK_USERNAME: vscode-actions
Expand All @@ -54,7 +56,8 @@ jobs:
uses: rtCamp/action-slack-notify@v2.0.2
env:
SLACK_CHANNEL: feed-vscode
SLACK_MESSAGE: "Published stable :white_check_mark:"
SLACK_TITLE: "Published stable :white_check_mark:"
SLACK_MESSAGE: ${{ steps.bump_versions.outputs.version }}
SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK }}
SLACK_ICON_EMOJI: ":ship:"
SLACK_USERNAME: vscode-actions
Expand All @@ -74,6 +77,7 @@ jobs:
- name: Bump versions
if: ${{ steps.check_for_updates.outputs.new_updates }}
run: yarn vsce:bump "dev"
id: bump_versions
- name: Compile
run: yarn compile
- name: Run headless e2e tests
Expand All @@ -89,7 +93,8 @@ jobs:
uses: rtCamp/action-slack-notify@v2.0.2
env:
SLACK_CHANNEL: feed-vscode
SLACK_MESSAGE: "Publishing Insider failed :x:"
SLACK_TITLE: "Publishing Insider Version failed :x:"
SLACK_MESSAGE: ${{ steps.bump_versions.outputs.version }}
SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK }}
SLACK_ICON_EMOJI: ":ship:"
SLACK_USERNAME: vscode-actions
Expand All @@ -99,7 +104,8 @@ jobs:
uses: rtCamp/action-slack-notify@v2.0.2
env:
SLACK_CHANNEL: feed-vscode
SLACK_MESSAGE: "Published Insider :white_check_mark:"
SLACK_TITLE: "Published Insider Version :white_check_mark:"
SLACK_MESSAGE: ${{ steps.bump_versions.outputs.version }}
SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK }}
SLACK_ICON_EMOJI: ":ship:"
SLACK_USERNAME: vscode-actions
Expand Down
2 changes: 2 additions & 0 deletions scripts/bump.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,8 @@ else
node scripts/change-readme.js "$RELEASE_CHANNEL"
fi

echo "::set-output name=version::$NEXT_EXTENSION_VERSION"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The indentation looks a bit off. Did you run shell lint?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, no I didn't. Will fix it.


jq ".version = \"$NEXT_EXTENSION_VERSION\" | \
.prisma.version = \"$SHA\" | \
.dependencies[\"@prisma/get-platform\"] = \"$NPM_VERSION\"" \
Expand Down