chore: show preview features in generator block as auto-completion su… #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janpio
reviewed
Jul 23, 2020
janpio
reviewed
Jul 23, 2020
Comment on lines
220
to
241
| "generatorPreviewFeatures": [ | ||
| { | ||
| "label": "distinct", | ||
| "documentation": "Enables distinct querying capabilities to Prisma Client. It allows you to query for distinct (unique) rows of a model. In other words: The fields you provide in the `distinct` argument will be duplicate free.\nDistinct is only a filter and doesn't change the return type of the `findMany` query.\n\nPlease [share your feedback](https://github.com/prisma/prisma/issues/2835) on how this feature works for you. We are interested in both positive and negative feedback, so we know if this feature is already ready for production! (If encounter any problems, please open a new issue [here](https://github.com/prisma/prisma/issues/new/choose))." | ||
| }, | ||
| { | ||
| "label": "middlewares", | ||
| "documentation": "Enables the Middlewares API allowing you to hook into the control flow of Prisma Client. Middlewares allows you to manipulate the parameters and interrogate the result of each query.\n\nPlease [share your feedback](https://github.com/prisma/prisma-client-js/issues/770) on how this feature works for you. We are interested in both positive and negative feedback, so we know if this feature is already ready for production! (If encounter any problems, please open a new issue [here](https://github.com/prisma/prisma/issues/new/choose))." | ||
| }, | ||
| { | ||
| "label": "connectOrCreate", | ||
| "documentation": "While Prisma Client already provides an `upsert` query, which is available on the top-level of the Prisma Client API, we now also support `upsert`s in a *nested* manner. When writing data with Prisma Client, both in `update` and `create`, you can now provide an `upsert` operation on a related row by using this feature flag.\n\nPlease [share](https://github.com/prisma/prisma-client-js/issues/336) your feedback on how this feature works for you. We are interested in both positive and negative feedback, so we know if this feature is already ready for production! (If encounter any problems, please open a new issue here)." | ||
| }, | ||
| { | ||
| "label": "transactionApi", | ||
| "documentation": "While Prisma already ships transactions within [nested writes](https://www.prisma.io/docs/reference/tools-and-interfaces/prisma-client/relation-queries#nested-writes), there are many use cases, where you might want to perform multiple *unrelated* write operations in a transaction and rollback, if one of them fails.\nBy wrapping your write operations in the new `transaction()` function, you can achieve exactly this!\n\n(Note, that these transactions are not long-running and are executed directly after each other. This is an explicit design decision of Prisma. In case this does not cover your use case yet, please chime in on [GitHub](https://github.com/prisma/prisma-client-js/issues/742)).\nAlternatively, you can store the unresolved promises in variables and pass these to the new transaction function.\n\n\n\nPlease [share your feedback](https://github.com/prisma/prisma-client-js/issues/667) on how this feature works for you. We are interested in both positive and negative feedback, so we know if this feature is already ready for production! (If encounter any problems, please open a new issue [here](https://github.com/prisma/prisma/issues/new/choose))." | ||
| }, | ||
| { | ||
| "label": "aggregateApi", | ||
| "documentation": "While Prisma Client already provides a `count` query for each model, we now introduce further aggregation functionality for number fields.\nIf your model has a field of type `Int` or `Float`, the following aggregations will be available:\n* sum: Sum up all values of a field for the selected rows.\n* min: Get the minimum value for a field for the selected rows.\n* max: Get the maximum value for a field for the selected rows.\n* avg: Get the average value for a field for the selected rows.\n\nPlease [share](https://github.com/prisma/prisma/issues/2838) your feedback on how this feature works for you. We are interested in both positive and negative feedback, so we know if this feature is already ready for production! (If encounter any problems, please open a new issue [here](https://github.com/prisma/prisma/issues/new/choose))." | ||
| } | ||
| ], |
There was a problem hiding this comment.
Ohhhhhh... that is interesting. I did not expect that we also suggest the values!
Hmm, quite a bit of maintenance at the same time. But probably worth it? @timsuchanek?
There was a problem hiding this comment.
Should each of them maybe link to the respective feedback issue that are linked here: prisma/prisma#3108?
There was a problem hiding this comment.
@nikolasburk Do you mean in addition to the link of the respective issue (e.g. prisma/prisma-client-js#667) or instead of it?
There was a problem hiding this comment.
We have new, individual feedback issues listed on prisma/prisma#3108 that people should use to leave feedback.
If those links are indeed clickable, that would be nice.
(@nikolasburk We should also go back to the release notes and update these.)
janpio
reviewed
Jul 23, 2020
janpio
reviewed
Jul 23, 2020
janpio
reviewed
Jul 23, 2020
Co-authored-by: Jan Piotrowski <piotrowski+github@gmail.com>
Co-authored-by: Jan Piotrowski <piotrowski+github@gmail.com>
…thub.com/prisma/language-tools into autocompletion_show_previewFeature_field
mhwelander
reviewed
Jul 27, 2020
mhwelander
reviewed
Jul 27, 2020
mhwelander
reviewed
Jul 27, 2020
mhwelander
reviewed
Jul 27, 2020
mhwelander
reviewed
Jul 27, 2020
mhwelander
reviewed
Jul 27, 2020
mhwelander
reviewed
Jul 27, 2020
mhwelander
reviewed
Jul 27, 2020
mhwelander
reviewed
Jul 27, 2020
Co-authored-by: Martina Welander <mhwelander@users.noreply.github.com>
Co-authored-by: Martina Welander <mhwelander@users.noreply.github.com>
Co-authored-by: Martina Welander <mhwelander@users.noreply.github.com>
Co-authored-by: Martina Welander <mhwelander@users.noreply.github.com>
Co-authored-by: Martina Welander <mhwelander@users.noreply.github.com>
janpio
reviewed
Jul 27, 2020
Co-authored-by: Jan Piotrowski <piotrowski+github@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #346