Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(lang-server): Add support for @@ignore and @ignore #685

Merged
merged 13 commits into from
Jan 29, 2021
Merged

feat(lang-server): Add support for @@ignore and @ignore #685

merged 13 commits into from
Jan 29, 2021

Conversation

sdnts
Copy link
Contributor

@sdnts sdnts commented Jan 29, 2021

No description provided.

@sdnts sdnts self-assigned this Jan 29, 2021
@sdnts sdnts added this to the 2.16.0 milestone Jan 29, 2021
@Jolg42 Jolg42 mentioned this pull request Jan 29, 2021
Closed
@Jolg42 Jolg42 linked an issue Jan 29, 2021 that may be closed by this pull request
Support for Unsupported, dbgenerated() and @@ignore #679
Closed
albertoperdomo
albertoperdomo approved these changes Jan 29, 2021
View reviewed changes
Copy link
Contributor

@albertoperdomo albertoperdomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a suggestion for improving the docs. If we merge these we are good to go.

packages/language-server/src/completion/completions.json Outdated Show resolved Hide resolved
packages/language-server/src/completion/completions.json Outdated Show resolved Hide resolved
albertoperdomo
albertoperdomo suggested changes Jan 29, 2021
View reviewed changes
Copy link
Contributor

@albertoperdomo albertoperdomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should merge the suggestions or change them if we want to. Otherwise good to go.

@sdnts
Copy link
Contributor Author

sdnts commented Jan 29, 2021

Removed @ignore since that isn't implemeted yet. Created a draft PR for it, I'll merge it before next sprint ends.

@sdnts sdnts merged commit ae7e747 into master Jan 29, 2021
@sdnts sdnts deleted the feature/ignore-attributes branch January 29, 2021 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jolg42 Jolg42 Jolg42 left review comments

@do4gr do4gr do4gr left review comments

@albertoperdomo albertoperdomo albertoperdomo requested changes

Assignees

@sdnts sdnts

Labels
None yet
Projects
None yet
Milestone
2.16.0
Development

Successfully merging this pull request may close these issues.

Support for Unsupported, dbgenerated() and @@ignore
4 participants
@sdnts @albertoperdomo @Jolg42 @do4gr