Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: auto completions (relation stop, name, more docs) #840

Merged
merged 8 commits into from Aug 19, 2021

Conversation

Jolg42
Copy link
Member

@Jolg42 Jolg42 commented Aug 18, 2021

And reorganize tests suite a bit

Closes #814

@Jolg42 Jolg42 added this to the 2.30.0 milestone Aug 18, 2021
Copy link
Member

@janpio janpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs tests 😆

The unrelated formatting changes indicate there might be something wrong with Prettier or some other configuration as well - should probably get an issue. If possible an earlier PR should change that formatting so the change here is focussed on what it actually does.

@Jolg42
Copy link
Member Author

Jolg42 commented Aug 19, 2021

Prettier cleanup done in #841

@Jolg42 Jolg42 marked this pull request as ready for review August 19, 2021 11:56
@janpio janpio self-requested a review August 19, 2021 12:02
Copy link
Member

@janpio janpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the suggestions this looks good to me 👍

Jolg42 and others added 4 commits August 19, 2021 14:57
Co-authored-by: Jan Piotrowski <piotrowski+github@gmail.com>
Co-authored-by: Jan Piotrowski <piotrowski+github@gmail.com>
Co-authored-by: Jan Piotrowski <piotrowski+github@gmail.com>
Co-authored-by: Jan Piotrowski <piotrowski+github@gmail.com>
@Jolg42 Jolg42 merged commit 5ee13c2 into main Aug 19, 2021
@Jolg42 Jolg42 deleted the pr/auto-completions-fixes branch August 19, 2021 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Autocomplete does not work for arguments after the first one in @relation()
2 participants