Skip to content
This repository has been archived by the owner on Aug 25, 2021. It is now read-only.

Migrate migration writes credentials out in the readme file #310

Closed
divyenduz opened this issue Jan 20, 2020 · 3 comments
Closed

Migrate migration writes credentials out in the readme file #310

divyenduz opened this issue Jan 20, 2020 · 3 comments
Assignees
@Jolg42
Labels
bug/2-confirmed We have confirmed that this is a bug. kind/bug A reported bug. tech/typescript Issue for tech TypeScript.
Milestone
2.1.0

Comments

@divyenduz
Copy link

They should be masked.
@divyenduz divyenduz added bug/0-needs-info More information is needed for reproduction. kind/bug A reported bug. labels Jan 20, 2020
@pantharshit00 pantharshit00 added bug/2-confirmed We have confirmed that this is a bug. process/candidate Candidate for next Milestone. and removed bug/0-needs-info More information is needed for reproduction. labels Jan 27, 2020
@divyenduz
Copy link
Author

Internal note: dropping from current sprint

@janpio janpio removed the process/candidate Candidate for next Milestone. label Jan 31, 2020
@Jolg42 Jolg42 changed the title Lift migration writes credentials out in the readme file Migrate migration writes credentials out in the readme file May 26, 2020
@pantharshit00
Copy link
Contributor

We do mask the credentials in the schema.prisma file stored inside of migrations folder:
image

but we do not mask them in the diff we generated in the README if they are hard coded:
image

@pantharshit00 pantharshit00 removed their assignment Jun 5, 2020
@pantharshit00 pantharshit00 added the process/candidate Candidate for next Milestone. label Jun 5, 2020
@janpio janpio added this to the 2.1.0 milestone Jun 11, 2020
@janpio janpio added the tech/typescript Issue for tech TypeScript. label Jun 11, 2020
@Jolg42 Jolg42 self-assigned this Jun 11, 2020
@janpio janpio removed the process/candidate Candidate for next Milestone. label Jun 11, 2020
Jolg42 added a commit to prisma/prisma that referenced this issue Jun 22, 2020
@Jolg42
chore(migrate): mask url in migration README
48b8fe6 
Related prisma/migrate#310
@mavilein mavilein mentioned this issue Jun 23, 2020
Closed
@timsuchanek
Copy link
Contributor

This is fixed in 2.1.1.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Jolg42 Jolg42

Labels
bug/2-confirmed We have confirmed that this is a bug. kind/bug A reported bug. tech/typescript Issue for tech TypeScript.
Projects
None yet
Milestone
2.1.0
Development

No branches or pull requests
5 participants
@janpio @divyenduz @timsuchanek @Jolg42 @pantharshit00