Foreign keys should not be created twice #2118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pimeys
changed the title
In a case where we need to recreate a table, if the table has a foreign key we have to change, this change could be run twice, leading to an error. The fix checks if the created foreign key references a table that was redefined earlier, and skips the creation if needed.
pimeys
force-pushed
the
migration-engine/sql-server-rename-columns-part-of-relations
branch
from
a2ffad0
to
99d6b24
Compare
do4gr
approved these changes
Aug 3, 2021
pimeys
deleted the
migration-engine/sql-server-rename-columns-part-of-relations
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a case where we need to recreate a table, if the table has a foreign key we have to change, this change could be run twice, leading to an error.
The fix checks if the created foreign key references a table that was redefined earlier, and skips the creation if needed.
Closes: prisma/prisma#8539