CI: Enable More SQL Server Tests #2119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
do4gr
reviewed
Aug 4, 2021
| #[test_connector(exclude(Mssql))] | ||
| fn reserved_sql_key_words_must_work(api: TestApi) { | ||
| #[test_connector] | ||
| fn reserved_sql_keywords_must_work(api: TestApi) { | ||
| // Group is a reserved keyword | ||
| let dm = r#" |
There was a problem hiding this comment.
For these you could use the new api.schema_push_w_datasource(dm1). This is adds the correct datasource and generator (generator should probably be mentioned in the method name). You'll probably get that already as merge conflict though.
There was a problem hiding this comment.
I'll do that in another review round later this week!
do4gr
approved these changes
Aug 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The remaining tests are mainly optional relations, where we can for now only have one null per column. We can enable those when we have the
allowNullValues: truein the foreign keys/indices.Closes: prisma/prisma#8544