fix: count & orderBy on one2m with multiple fks #2145
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes prisma/prisma#7299
Fixes prisma/prisma#7331
This PR also fixes an
orderByRelation
issue (7331 above) which is using thecompute_one2m_join
function that I batched fixed in this PR as the root cause was exactly the same as the count aggregation one.Changes
LEFT JOIN
in charge of computing the count aggregation changes from (pseudo-sql):to: