fix: order by m2m with disconnected records #2150
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes prisma/prisma#8036
Count aggregations on m2m were done from the join table and joined the relation tables. While this worked, it only returned records that had a count > 0.
This flawed the cursor logic, which needs to have all the records (the ones with a relation count > 0 and the ones without any connected records) to properly truncate the result set.
Instead of selecting from the join table (which contains only the connected records), we're now selecting from the base model and left joining the join table.