Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: json numeric filter #2151

Closed
wants to merge 23 commits into from
Closed

fix: json numeric filter #2151

wants to merge 23 commits into from

Conversation

Weakky
Copy link
Member

@Weakky Weakky commented Aug 13, 2021

Overview

Deeper dive

  • On Postgres, we were applying ASCII comparison instead of numeric comparison
  • On MySQL and MariaDB, we're doing the comparisons against the deserialized json values

@Weakky Weakky added this to the 2.30.0 milestone Aug 13, 2021
Weakky and others added 22 commits August 16, 2021 12:06
* add test and workaround

* review feedback
…2156)

* Make `DefaultValue` a struct

* Actually migrate named defaults

* Start testing

* More tests

* Rest of the test, ME/IE + PSL lower

* Make `DefaultValue` properties private.

* clippy

* clippy

* Remove DRY parts

* Fix error string

* Use db_names to define the default constraint name

* clippy
* CI: Run clippy/format on GH Actions

* Cache dependencies on builds

* Remove -Dwarnings

* Stable toolchain for clippy

* Deal with clippy warnings

* Engineer 1.21
* (WIP) Print cycle paths for referential actions

* Split the cycle detection to a new file.

Make also the interface nicer.

Co-authored-by: Julius de Bruijn <julius+github@nauk.io>
* CI: Clippy warnings as errors

* Collapse two if statements
The actions should be defined from the side of `fields` and `references`.
* fix m2m relationname inferrence. We cannot change the relationname for m2m relations since the QE derives the table name from that

* clippy
Co-authored-by: Renovate Bot <bot@renovateapp.com>
@CLAassistant
Copy link

CLAassistant commented Aug 23, 2021

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
5 out of 6 committers have signed the CLA.

✅ janpio
✅ Weakky
✅ tomhoule
✅ pimeys
✅ do4gr
❌ renovate[bot]
You have signed the CLA already but the status is still pending? Let us recheck it.

@Weakky Weakky closed this Aug 23, 2021
@janpio janpio deleted the fix/json-numeric-compare branch November 15, 2023 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSON number filtering bug
5 participants