PSL: Implementing map field for @default attribute on SQL Server
#2156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pimeys
force-pushed
the
sql-server/default-constraint-name
branch
from
cbee5e3
to
7be2e7b
Compare
tomhoule
reviewed
Aug 17, 2021
| } | ||
|
|
||
| db_name.map(|cow| cow.to_string()) | ||
| } |
There was a problem hiding this comment.
I already had concerns and re-read the code for constraint names validation in attributes.rs, now I'm certain we should change the approach asap, we're going down the wrong path (this code does not belong here). Do you have time for a call today so we can sketch the better approach? I'd also be fine merging this and correcting later, but it's only getting more expensive to fix.
There was a problem hiding this comment.
We'll have a call later. Let's do this!
There was a problem hiding this comment.
On a call, we as a team decided to redo this after GA.
do4gr
reviewed
Aug 17, 2021
introspection-engine/connectors/sql-introspection-connector/src/introspection_helpers.rs
Outdated
Show resolved
Hide resolved
do4gr
reviewed
Aug 17, 2021
do4gr
reviewed
Aug 17, 2021
Weakky
pushed a commit
that referenced
this pull request
Aug 23, 2021
…2156) * Make `DefaultValue` a struct * Actually migrate named defaults * Start testing * More tests * Rest of the test, ME/IE + PSL lower * Make `DefaultValue` properties private. * clippy * clippy * Remove DRY parts * Fix error string * Use db_names to define the default constraint name * clippy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: prisma/prisma#8158