Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print cycle paths for referential actions #2163

Merged
merged 2 commits into from Aug 18, 2021
Merged

Conversation

tomhoule
Copy link
Contributor

@tomhoule tomhoule commented Aug 18, 2021

@pimeys pimeys changed the title (WIP) Print cycle paths for referential actions Print cycle paths for referential actions Aug 18, 2021
@pimeys pimeys marked this pull request as ready for review August 18, 2021 14:44
@pimeys
Copy link
Contributor

pimeys commented Aug 18, 2021

Paired with Tom, reviewed together.

@pimeys pimeys force-pushed the datamodel/print-cycle-paths branch from add6c5d to 80096e2 Compare August 18, 2021 16:28
@pimeys pimeys added this to the 2.30.0 milestone Aug 18, 2021
@pimeys pimeys merged commit b404b6c into master Aug 18, 2021
@pimeys pimeys deleted the datamodel/print-cycle-paths branch August 18, 2021 17:07
Weakky pushed a commit that referenced this pull request Aug 23, 2021
* (WIP) Print cycle paths for referential actions

* Split the cycle detection to a new file.

Make also the interface nicer.

Co-authored-by: Julius de Bruijn <julius+github@nauk.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better error for cyclical referential actions
2 participants