MongoDb: 2-way Embedded M:N Relations #2671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pimeys
force-pushed
the
parser-database/2-way-embedded-many-to-many-relations
branch
5 times, most recently
from
8ff5a08
to
339549e
Compare
Sets to stone how these should look like, instead of hacking them together.
Introduces a new many-to-many relation definition only for MongoDB:
```prisma
model A {
id String @id @Map("_id") @default(auto()) @test.ObjectId
b_ids String[] @test.ObjectId
bs B[] @relation(fields: [b_ids], references: [id])
}
model B {
id String @id @Map("_id") @default(auto()) @test.ObjectId
a_ids String[] @test.ObjectId
as A[] @relation(fields: [a_ids], references: [id])
}
```
Both models hold a list of identifiers in an array. Using this list, we build a
relation to another model pointing to an identifier of that model. From the
other model we again define a relation from an array to an identifier. This
forms an embedded 2-way many-to-many relation with the following rules:
- Detected as an embedded relation if any of the sides defines `fields` argument.
- Only allowed in MongoDb.
- Both sides must define `fields` and `references`.
- The `fields` argument must point to an array scalar field.
- The `references` argument must point to an id field that must be of same type
as the `fields` array scalar.
- No referential actions are allowed in these relations for now.
pimeys
force-pushed
the
parser-database/2-way-embedded-many-to-many-relations
branch
from
339549e
to
af852b7
Compare
do4gr
reviewed
Feb 10, 2022
do4gr
reviewed
Feb 10, 2022
.../src/transform/ast_to_dml/validation_pipeline/validations/relations/many_to_many/implicit.rs
Outdated
Show resolved
Hide resolved
janpio
reviewed
Feb 11, 2022
| if !relation_field.references_singular_id_field() { | ||
| ctx.push_error(DatamodelError::new_validation_error( | ||
| format!( | ||
| "Many to many relations must always reference the id field of the related model. Change the argument `references` to use the id field of the related model `{}`. But it is referencing the following fields that are not the id: {}", |
There was a problem hiding this comment.
Suggested change
| "Many to many relations must always reference the id field of the related model. Change the argument `references` to use the id field of the related model `{}`. But it is referencing the following fields that are not the id: {}", | |
| "Implicit many to many relations must always reference the id field of the related model. Change the argument `references` to use the id field of the related model `{}`. But it is referencing the following fields that are not the id: {}", |
There was a problem hiding this comment.
tbd but I think it's all many-to-many relations
There was a problem hiding this comment.
Don't know who to believe then :D #2671 (comment)
There was a problem hiding this comment.
I think you might actually be right now. If this also applies to the new MongoDB relation, that one is not really implicit as it has the explicit arrays for storing the references.
tomhoule
reviewed
Feb 11, 2022
.../src/transform/ast_to_dml/validation_pipeline/validations/relations/many_to_many/embedded.rs
Show resolved
Hide resolved
tomhoule
reviewed
Feb 11, 2022
.../src/transform/ast_to_dml/validation_pipeline/validations/relations/many_to_many/embedded.rs
Show resolved
Hide resolved
tomhoule
reviewed
Feb 11, 2022
tomhoule
approved these changes
Feb 11, 2022
pimeys
deleted the
parser-database/2-way-embedded-many-to-many-relations
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets to stone how these should look like, instead of hacking them together. Introduces a new many-to-many relation definition only for MongoDB:
Both models hold a list of identifiers in an array. Using this list, we build a relation to another model pointing to an identifier of that model. From the other model we again define a relation from an array to an identifier. This forms an embedded 2-way many-to-many relation with the following rules:
fieldsargument.fieldsandreferences.fieldsargument must point to an array scalar field.referencesargument must point to an id field that must be of same type as thefieldsarray scalar.Closes: prisma/prisma#11553