reformatting: Fix spacing between attributes in edge cases #2833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 1:1 relations, the reformatter can add `@unique` attributes. If they come after a native type attribute, the reformatter failed to add adequate spacing between the attributes, resulting in valid but odd looking schemas. This commit fixes that problem. These schemas are also not idempotent, because of interactions between attribute sorting and missing attributes addition. Issue: prisma/prisma#12726 closes prisma/prisma#12596
tomhoule
force-pushed
the
format/weird-at-unique
branch
2 times, most recently
from
28d077d
to
aa58c9a
Compare
Popped up with rust 1.60 yesterday.
tomhoule
force-pushed
the
format/weird-at-unique
branch
from
aa58c9a
to
85a4e97
Compare
pimeys
approved these changes
Apr 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 1:1 relations, the reformatter can add
@uniqueattributes. If theycome after a native type attribute, the reformatter failed to add
adequate spacing between the attributes, resulting in valid but odd
looking schemas. This commit fixes that problem.
These schemas are also not idempotent, because of interactions between
attribute sorting and missing attributes addition. Issue:
prisma/prisma#12726
closes prisma/prisma#12596