Remove support for type aliases #2942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomhoule
reviewed
May 30, 2022
| [1;94m | [0m | ||
| [1;94m 1 | [0m[1;91mtype MyString = String @default("B")[0m | ||
| [1;94m | [0m | ||
| "#]]; |
There was a problem hiding this comment.
let's validate the error message with product if in doubt
There was a problem hiding this comment.
I'm not that much in doubt with this. Undocumented feature gets removed and we just give a hard validation error for now.
There was a problem hiding this comment.
+1 on treating these as they never happened (in this one, special case of the old, undocumented type)
pimeys
force-pushed
the
prisma-4/remove-type-alias
branch
from
0c711a1
to
5e3b744
Compare
pimeys
force-pushed
the
prisma-4/remove-type-alias
branch
from
5e3b744
to
790df80
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not merge before Prisma 4 is due.
Closes prisma/prisma#9939